Summary: | AutoEmailPrimaryAddress options don't match labels in memberentry | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Staff interface | Assignee: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, dcook, gmcharlt, m.de.rooy, matt.blenkinsop |
Version: | unspecified | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 |
||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement changes the wording of the choices in the EmailFieldPrimary system preference (formely AutoEmailPrimaryAddress) to match the patron form field names.
The choices were changed like so:
- 'home' is now called 'primary email' and refers to the email database column
- 'work' is now called 'secondary email' and refers to the emailpro database column
- 'alternate' is still called 'alternate email' and refers to the B_email database column
- first valid and cardnumber did not change.
|
Version(s) released in: |
23.05.00
|
Circulation function: | |||
Bug Depends on: | 33192 | ||
Bug Blocks: | |||
Attachments: |
Bug 33191: AutoEmailPrimaryAddress options don't match labels in memberentry
Bug 33191: AutoEmailPrimaryAddress options don't match labels in memberentry Bug 33191: AutoEmailPrimaryAddress options don't match labels in memberentry Bug 33191: AutoEmailPrimaryAddress options don't match labels in memberentry |
Description
Martin Renvoize (ashimema)
2023-03-10 08:34:19 UTC
Here is the corresponding field names Current syspref choices | DB field | Field name in patronfields.inc ------------------------+----------+------------------------------- home | email | Primary email ------------------------+----------+------------------------------- work | emailpro | Secondary email ------------------------+----------+------------------------------- alternate | B_email | Alternate email Created attachment 148098 [details] [review] Bug 33191: AutoEmailPrimaryAddress options don't match labels in memberentry This patch changes the wording for the AutoEmailPrimaryAddress system preference to make it clearer. To test: 1. Go to Administration > Global system preferences 2. Search for AutoEmailPrimaryAddress 3. Read the sentence and choices, make sure it makes sense, grammar and spelling are correct 4. Click the link to AutoEmailNewUser, it should bring up the correct system preference 5. Optionally, try the different options, they should work as before I submitted something. It only changes the wording of the preference. If you'd prefer the modal like BorrowerMandatoryField for example, that's a bit outside my knowledge, but I guess I could do some copy-paste and figure it out :) Thanks Caroline, the select options change is perfect. You've fallen into the same trap I did however regards linking the preference to AutoEmailNewUser.. in actual fact, this preference isn't that closely related to that preference, it applies to a lot more notices than just the welcome one. I've actually opened a bug to rename this pref and also to expand it with yet another preference to govern the order of the 'first valid' option from here. I'll take a deeper look on Monday with the aim of signing off. :) Ok, maybe this bug should be the last in the series to be corrected then? 1st bug 33192 2nd bug 29046 3rd this We may as well add in bug 18398 to the little tree that's building here too.. Perhaps we should also look at updateing the uses of first_valid_email listed above to also use notice_email_address as another bug in this set? Created attachment 148141 [details] [review] Bug 33191: AutoEmailPrimaryAddress options don't match labels in memberentry This patch changes the wording for the EmailFieldPrimary system preference to make it clearer. To test: 1. Go to Administration > Global system preferences 2. Search for EmailFieldPrimary 3. Read the sentence and choices, make sure it makes sense, grammar and spelling are correct 4. Optionally, try the different options, they should work as before Redid the choices on top of the name change (bug 33192) Created attachment 148156 [details] [review] Bug 33191: AutoEmailPrimaryAddress options don't match labels in memberentry This patch changes the wording for the EmailFieldPrimary system preference to make it clearer. To test: 1. Go to Administration > Global system preferences 2. Search for EmailFieldPrimary 3. Read the sentence and choices, make sure it makes sense, grammar and spelling are correct 4. Optionally, try the different options, they should work as before Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Excellent, I think this all starts to become a lot more clear now :) Created attachment 149640 [details] [review] Bug 33191: AutoEmailPrimaryAddress options don't match labels in memberentry This patch changes the wording for the EmailFieldPrimary system preference to make it clearer. To test: 1. Go to Administration > Global system preferences 2. Search for EmailFieldPrimary 3. Read the sentence and choices, make sure it makes sense, grammar and spelling are correct 4. Optionally, try the different options, they should work as before Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 23.05. Nice work everyone, thanks! Not backporting to 22.11.x as bug 33192 is an enhancement and has not been backported Nice work everyone! |