Summary: | Recalls to pull should not show in transit or allocated items | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Circulation | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | minor | ||
Priority: | P5 - low | CC: | andrew.auld, gmcharlt, kyle.m.hall, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.07
|
|
Circulation function: | |||
Bug Depends on: | 19532 | ||
Bug Blocks: | |||
Attachments: |
Bug 33220: Fix recalls to pull to not show in transit or allocated items
Bug 33220: Fix recalls to pull to not show in transit or allocated items Bug 33220: Fix recalls to pull to not show in transit or allocated items |
Description
Aleisha Amohia
2023-03-14 04:17:35 UTC
Created attachment 148151 [details] [review] Bug 33220: Fix recalls to pull to not show in transit or allocated items This patch fixes the Recalls to pull circulation report so that it does not show items that are already allocated to another recall. This requires the UseRecalls system preference to be enabled and recalls circulation and fines rules to be configured. To test: 1. Cancel any recalls on Item A/Biblio A. 2. Check out Item A to Patron A. Item A should be the only item on Biblio A (pick a record with only one item, or create a record with one item). 2. Log into the OPAC as Patron B. 3. Place a recall on Item A for Patron B. Change the pickup library so it isn't your default library. 4. Log into the OPAC as Patron C. 5. Place a recall on Item A for Patron C. Item A should now be checked out to Patron A, with two recalls on it for Patrons B and C. 6. Log back into the staff interface. 7. Check in Item A. Confirm the recall and transfer for Patron B. 8. Go to Circulation -> Recalls to pull. Notice the recall for Patron C shows here, even though the one item that could fill this recall has already been allocated to Patron B and is in transit 9. Apply the patch and restart services 10. Refresh the Recalls to pull page 11. Confirm the recall no longer shows on the Recalls to pull page --> SUCCESS 12. Go to Biblio A and add a second item - Item B 13. Go back to Recalls to pull and refresh the page 14. Confirm the recall for Patron C now shows and can be filled by Item B Sponsored-by: Auckland University of Technology Created attachment 149121 [details] [review] Bug 33220: Fix recalls to pull to not show in transit or allocated items This patch fixes the Recalls to pull circulation report so that it does not show items that are already allocated to another recall. This requires the UseRecalls system preference to be enabled and recalls circulation and fines rules to be configured. To test: 1. Cancel any recalls on Item A/Biblio A. 2. Check out Item A to Patron A. Item A should be the only item on Biblio A (pick a record with only one item, or create a record with one item). 2. Log into the OPAC as Patron B. 3. Place a recall on Item A for Patron B. Change the pickup library so it isn't your default library. 4. Log into the OPAC as Patron C. 5. Place a recall on Item A for Patron C. Item A should now be checked out to Patron A, with two recalls on it for Patrons B and C. 6. Log back into the staff interface. 7. Check in Item A. Confirm the recall and transfer for Patron B. 8. Go to Circulation -> Recalls to pull. Notice the recall for Patron C shows here, even though the one item that could fill this recall has already been allocated to Patron B and is in transit 9. Apply the patch and restart services 10. Refresh the Recalls to pull page 11. Confirm the recall no longer shows on the Recalls to pull page --> SUCCESS 12. Go to Biblio A and add a second item - Item B 13. Go back to Recalls to pull and refresh the page 14. Confirm the recall for Patron C now shows and can be filled by Item B Sponsored-by: Auckland University of Technology Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Great patch and test script...all works perfectly as described. Changes make sense, works as described, QA scripts are happy. Created attachment 150389 [details] [review] Bug 33220: Fix recalls to pull to not show in transit or allocated items This patch fixes the Recalls to pull circulation report so that it does not show items that are already allocated to another recall. This requires the UseRecalls system preference to be enabled and recalls circulation and fines rules to be configured. To test: 1. Cancel any recalls on Item A/Biblio A. 2. Check out Item A to Patron A. Item A should be the only item on Biblio A (pick a record with only one item, or create a record with one item). 2. Log into the OPAC as Patron B. 3. Place a recall on Item A for Patron B. Change the pickup library so it isn't your default library. 4. Log into the OPAC as Patron C. 5. Place a recall on Item A for Patron C. Item A should now be checked out to Patron A, with two recalls on it for Patrons B and C. 6. Log back into the staff interface. 7. Check in Item A. Confirm the recall and transfer for Patron B. 8. Go to Circulation -> Recalls to pull. Notice the recall for Patron C shows here, even though the one item that could fill this recall has already been allocated to Patron B and is in transit 9. Apply the patch and restart services 10. Refresh the Recalls to pull page 11. Confirm the recall no longer shows on the Recalls to pull page --> SUCCESS 12. Go to Biblio A and add a second item - Item B 13. Go back to Recalls to pull and refresh the page 14. Confirm the recall for Patron C now shows and can be filled by Item B Sponsored-by: Auckland University of Technology Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to 22.11.x for next release |