| Summary: | OPAC advanced search inputs stay disabled when using browser's back button | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | OPAC | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | barbara.johnson, bwsdonna, danyonsewell |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06,22.05.14,21.11.22
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 34857 | ||
| Attachments: |
Bug 33233: Don't allow disabled attribute to remain when using browser's back button
Bug 33233: Don't allow disabled attribute to remain when using browser's back button Bug 33233: Don't allow disabled attribute to remain when using browser's back button |
||
|
Description
Lucas Gass (lukeg)
2023-03-15 12:57:21 UTC
This is really confusing for staff and patrons! I know the preferred behavior is to click the link to Return to last advanced search, but that is not a floating link, so unless you are at the top of the page, you don't see it. Typical use by a patron/staff is to do the search, scroll down the first page of results, and if the search is not on target, hit the back arrow and refine the search. The specifics of the search should be retained, but the user needs the ability to add additional fields etc. There seems to be a pretty large variation here depending on what browser is being used. Maybe it would be better to deal with these empty values at the script level, instead of in the templates? Created attachment 149476 [details] [review] Bug 33233: Don't allow disabled attribute to remain when using browser's back button To test: 1. Go to OPAC advanced search and do a search using only one of the inputs. 2. Once the search is complete use the browser's back button to return to the advanced search. 3. Notice the unused inputs are disabled. 4. Apply patch and try again. Now the inputs should not be disabled. Created attachment 149701 [details] [review] Bug 33233: Don't allow disabled attribute to remain when using browser's back button To test: 1. Go to OPAC advanced search and do a search using only one of the inputs. 2. Once the search is complete use the browser's back button to return to the advanced search. 3. Notice the unused inputs are disabled. 4. Apply patch and try again. Now the inputs should not be disabled. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> This worked great - so glad to see this fixed. Created attachment 150141 [details] [review] Bug 33233: Don't allow disabled attribute to remain when using browser's back button To test: 1. Go to OPAC advanced search and do a search using only one of the inputs. 2. Once the search is complete use the browser's back button to return to the advanced search. 3. Notice the unused inputs are disabled. 4. Apply patch and try again. Now the inputs should not be disabled. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release Backported to 22.05.x for upcoming 22.05.14 Backported to 21.11.x for upcoming 21.11.22 |