Bug 33272

Summary:	Color of the "(remove)" link when an item is in the cart (OPAC)
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	jacob.omara, lucas
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.05.00,22.11.05
Circulation function:
Attachments:	Bug 33272: Color of the "(remove)" link when an item is in the cart (OPAC) Bug 33272: Color of the "(remove)" link when an item is in the cart (OPAC) Bug 33272: Color of the "(remove)" link when an item is in the cart (OPAC)

Description Caroline Cyr La Rose 2023-03-17 20:36:15 UTC

When search results are in the cart, there is a "In your cart (remove)" mention under the search result. The "(remove)" part is either blue or red depending on the background color/if the search result is even or odd.

To replicate:
1. Make a search in the OPAC that will give you 3+ results
2. Check the first three results and select "Add to: Cart" at the top of the results
   --> Note that for the first result, "In you cart (remove)" is blue
   --> Note that for the second result, the (remove) part is red
   --> The third result is like the first

Comment 1 Owen Leonard 2023-03-22 11:57:42 UTC

Created attachment 148520 [details] [review]
Bug 33272: Color of the "(remove)" link when an item is in the cart (OPAC)

This patch improves the CSS for styling the OPAC cart's "remove" link in
search results so that the color is consistent within alternating table
row colors.

To test, apply the patch and rebuild the OPAC CSS.

- Perform a search in the OPAC which will return multiple results.
- Click the "Add to cart" link next to multiple results.
- The "remove" link which appears should be the correct red color
  whether the table row background is white or grey.

Comment 2 Caroline Cyr La Rose 2023-03-22 13:36:04 UTC

Created attachment 148548 [details] [review]
Bug 33272: Color of the "(remove)" link when an item is in the cart (OPAC)

This patch improves the CSS for styling the OPAC cart's "remove" link in
search results so that the color is consistent within alternating table
row colors.

To test, apply the patch and rebuild the OPAC CSS.

- Perform a search in the OPAC which will return multiple results.
- Click the "Add to cart" link next to multiple results.
- The "remove" link which appears should be the correct red color
  whether the table row background is white or grey.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Comment 3 Caroline Cyr La Rose 2023-03-22 13:36:25 UTC

Thanks Owen!

Comment 4 Nick Clemens (kidclamp) 2023-04-01 23:18:09 UTC

Created attachment 149072 [details] [review]
Bug 33272: Color of the "(remove)" link when an item is in the cart (OPAC)

This patch improves the CSS for styling the OPAC cart's "remove" link in
search results so that the color is consistent within alternating table
row colors.

To test, apply the patch and rebuild the OPAC CSS.

- Perform a search in the OPAC which will return multiple results.
- Click the "Add to cart" link next to multiple results.
- The "remove" link which appears should be the correct red color
  whether the table row background is white or grey.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Comment 5 Tomás Cohen Arazi (tcohen) 2023-04-06 12:30:36 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 6 Jacob O'Mara 2023-04-16 20:37:50 UTC

Nice work, thanks everyone!

Pushed to 22.11.x for the next release.

Comment 7 Lucas Gass (lukeg) 2023-05-05 21:30:05 UTC

Does not apply clean in 22.05.x, no backport.

Comment 8 Katrin Fischer 2023-05-14 10:59:26 UTC

Created attachment 151167 [details]
k