Summary: | Library limitations will cause data loss when editing locations in the subscription form | ||
---|---|---|---|
Product: | Koha | Reporter: | Thibaud Guillot (thibaud_g) <thibaud.guillot> |
Component: | Serials | Assignee: | Thibaud Guillot (thibaud_g) <thibaud.guillot> |
Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | michaela.sieber, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 33276: Get auth values for location on serials
Bug 33276: Get auth values for location on serials |
Description
Thibaud Guillot (thibaud_g)
2023-03-20 13:06:23 UTC
Hi Thibaud, I think the item form in acquisitions is also based on the same code as the one in serials. Created attachment 148412 [details] [review] Bug 33276: Get auth values for location on serials Serial location is linked to a library, if we want to modify serial with users does not belongs to, location is not in select and we could erase it. Test plan: 1) Be sure to have a LOC authorized value limited to one library at least 2) See when editing serial subscription you didn't get the current location 3) Apply this patch 4) Refresh and now you've got the value (In reply to Katrin Fischer from comment #1) > Hi Thibaud, I think the item form in acquisitions is also based on the same > code as the one in serials. Hi Katrin, Hum.. I wrote a patch but it's not like in items, the form isn't generated on the same way.. or I miss up :/ (In reply to Thibaud Guillot from comment #3) > (In reply to Katrin Fischer from comment #1) > > Hi Thibaud, I think the item form in acquisitions is also based on the same > > code as the one in serials. > > Hi Katrin, > > Hum.. I wrote a patch but it's not like in items, the form isn't generated > on the same way.. or I miss up :/ What I meant: The item forms in Koha are built with different code: * Cataloguing / Item form * Serial item form / Acquisition item form But I misunderstood your patch: you are updating the location in the subscription form. That's also a great catch and I am very happy to see more and more of these issues fixed! There is also an option to set the collection for the subscription now, I think we'll need the same fix there. What do you think? Created attachment 148958 [details] [review] Bug 33276: Get auth values for location on serials Serial location is linked to a library, if we want to modify serial with users does not belongs to, location is not in select and we could erase it. Test plan: 1) Be sure to have a LOC authorized value limited to one library at least 2) See when editing serial subscription you didn't get the current location 3) Apply this patch 4) Refresh and now you've got the value Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> This is missing the category parameter in the search - so it may pull a matching value form another category. It looks like Jonathan added comments on 32748 that need to be addressed here as well. We should develop a centralized fix in GetAuthorisedValues, or move things to Koha namespace |