| Summary: | Use template wrapper for tabs: Checkout history | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | jacob.omara, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.05
|
|
| Circulation function: | |||
| Bug Depends on: | 32571 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 33294: Use template wrapper for tabs: Checkout history
Bug 33294: Use template wrapper for tabs: Checkout history Bug 33294: Use template wrapper for tabs: Checkout history |
||
|
Description
Owen Leonard
2023-03-21 16:41:49 UTC
Created attachment 148485 [details] [review] Bug 33294: Use template wrapper for tabs: Checkout history This patch updates the checkout history template so that it uses the new WRAPPER directive to build tabbed navigation. In order to make the template logic a little easier to parse I moved the table of checkouts into its own BLOCK to be used when on-site checkouts are enabled or disabled. To test, apply the patch and locate a patron who has a checkout history. - If you have on-site checkouts enabled you will see three tabs: All, Checkouts, and On-site checkouts. - Each tab should work correctly: The checkouts tab showing only regular checkouts, the on-site checkouts tab showing only on-site checkouts. - If you have on-site checkouts disabled there should be no tabs, the table of checkouts should be displayed inside a "page-section" div instead. Created attachment 148754 [details] [review] Bug 33294: Use template wrapper for tabs: Checkout history This patch updates the checkout history template so that it uses the new WRAPPER directive to build tabbed navigation. In order to make the template logic a little easier to parse I moved the table of checkouts into its own BLOCK to be used when on-site checkouts are enabled or disabled. To test, apply the patch and locate a patron who has a checkout history. - If you have on-site checkouts enabled you will see three tabs: All, Checkouts, and On-site checkouts. - Each tab should work correctly: The checkouts tab showing only regular checkouts, the on-site checkouts tab showing only on-site checkouts. - If you have on-site checkouts disabled there should be no tabs, the table of checkouts should be displayed inside a "page-section" div instead. Works as advertised. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 149319 [details] [review] Bug 33294: Use template wrapper for tabs: Checkout history This patch updates the checkout history template so that it uses the new WRAPPER directive to build tabbed navigation. In order to make the template logic a little easier to parse I moved the table of checkouts into its own BLOCK to be used when on-site checkouts are enabled or disabled. To test, apply the patch and locate a patron who has a checkout history. - If you have on-site checkouts enabled you will see three tabs: All, Checkouts, and On-site checkouts. - Each tab should work correctly: The checkouts tab showing only regular checkouts, the on-site checkouts tab showing only on-site checkouts. - If you have on-site checkouts disabled there should be no tabs, the table of checkouts should be displayed inside a "page-section" div instead. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. |