|
Description
Fridolin Somers
2023-03-22 08:01:40 UTC
Created attachment 148503 [details] [review] Bug 33297: Fix typo system preference RetainPatronSearchTerms in DB revs 220600044.pl Bug 26247 added system preference RetainPatronsSearchTerms. There is a typo in DB revs 220600044.pl : RetainPatronSearchTerms instead of RetainPatronsSearchTerms. Test plan : Upgrade from 22.05 to 22.11 and check there is a system preference named 'RetainPatronsSearchTerms' Tell me if we should also fix already updated databases ? > (22:11:30) Joubu: fridolin: then you need a new db revs for those who upgraded already
Created attachment 148504 [details] [review] Bug 33297: (follow-up) DBRev for existing databases Test plan : 1.1) Start from a Koha 22.05 1.2) Upgrade to master => Check the upgrade says : Wrong system preference 'RetainPatronSearchTerms' renamed 'RetainPatronsSearchTerms' 2.1) Start from a Koha 22.05 2.2) Upgrade to 22.11 2.3) Via interface change system preference 'RetainPatronsSearchTerms' and save 2.4) Upgrade to master => Check the upgrade says : Wrong system preference 'RetainPatronSearchTerms' deleted *** Bug 33291 has been marked as a duplicate of this bug. *** Created attachment 148582 [details] [review] Bug 33297: Fix typo system preference RetainPatronSearchTerms in DB revs 220600044.pl Bug 26247 added system preference RetainPatronsSearchTerms. There is a typo in DB revs 220600044.pl : RetainPatronSearchTerms instead of RetainPatronsSearchTerms. Test plan : Upgrade from 22.05 to 22.11 and check there is a system preference named 'RetainPatronsSearchTerms' Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 148583 [details] [review] Bug 33297: (follow-up) DBRev for existing databases Test plan : 1.1) Start from a Koha 22.05 1.2) Upgrade to master => Check the upgrade says : Wrong system preference 'RetainPatronSearchTerms' renamed 'RetainPatronsSearchTerms' 2.1) Start from a Koha 22.05 2.2) Upgrade to 22.11 2.3) Via interface change system preference 'RetainPatronsSearchTerms' and save 2.4) Upgrade to master => Check the upgrade says : Wrong system preference 'RetainPatronSearchTerms' deleted Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> trivial, SO+QA in one step No blocker, but the dbrev says 'deleted' even when it did not delete (since there was none).. Created attachment 148584 [details] [review] Bug 33297: (follow-up) DBRev check wrong preference exists Better db upgrade messages (In reply to Marcel de Rooy from comment #9) > No blocker, but the dbrev says 'deleted' even when it did not delete (since > there was none).. Oh indeed, follow-up added. Hoping to look at these soon... (In reply to David Cook from comment #12) > Hoping to look at these soon... How soon? (In reply to Jonathan Druart from comment #13) > (In reply to David Cook from comment #12) > > Hoping to look at these soon... > > How soon? Alas, I've given up hope for now. I'd like to test, but don't know how to do step 1.2 (upgrading from 22.05 to master) using KTD (koha-testing-docker). If I could get some instructions on how to do that, I'll happily test. Created attachment 151280 [details] [review] Bug 33297: Fix typo system preference RetainPatronSearchTerms in DB revs 220600044.pl Bug 26247 added system preference RetainPatronsSearchTerms. There is a typo in DB revs 220600044.pl : RetainPatronSearchTerms instead of RetainPatronsSearchTerms. Test plan : Upgrade from 22.05 to 22.11 and check there is a system preference named 'RetainPatronsSearchTerms' Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 151281 [details] [review] Bug 33297: (follow-up) DBRev for existing databases Test plan : 1.1) Start from a Koha 22.05 1.2) Upgrade to master => Check the upgrade says : Wrong system preference 'RetainPatronSearchTerms' renamed 'RetainPatronsSearchTerms' 2.1) Start from a Koha 22.05 2.2) Upgrade to 22.11 2.3) Via interface change system preference 'RetainPatronsSearchTerms' and save 2.4) Upgrade to master => Check the upgrade says : Wrong system preference 'RetainPatronSearchTerms' deleted Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 151282 [details] [review] Bug 33297: (follow-up) DBRev check wrong preference exists Better db upgrade messages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to David Nind from comment #15) > I'd like to test, but don't know how to do step 1.2 (upgrading from 22.05 to > master) using KTD (koha-testing-docker). > > If I could get some instructions on how to do that, I'll happily test. % git checkout v22.05.00 % reset_all % git checkout master > SELECT variable from systempreferences where variable like "%RetainPatron%"; I am not sure about "Wrong system preference 'RetainPatronSearchTerms' does not exist" I would say: If nothing is wrong, then tell nothing. It could be confusing. (In reply to Jonathan Druart from comment #20) > I am not sure about "Wrong system preference 'RetainPatronSearchTerms' does > not exist" > > I would say: If nothing is wrong, then tell nothing. It could be confusing. Agreed. Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to 22.11.x for next release |