Bug 33299

Summary: Item type column is empty when placing item level holds in OPAC
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: OPACAssignee: Mark Hofstetter <koha>
Status: RESOLVED FIXED QA Contact: Nick Clemens <nick>
Severity: minor    
Priority: P5 - low CC: amaury.gau, jacob.omara, koha, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Bug Depends on: 31314    
Bug Blocks:    
Attachments: Bug 33299: Item type column displays translated_description when placing item level holds in OPAC
Bug 33299: Item type column displays translated_description when placing item level holds in OPAC
Bug 33299: Item type column displays translated_description when placing item level holds in OPAC

Description Katrin Fischer 2023-03-22 08:38:37 UTC
When placing an item level hold in the OPAC, the column for item types is empty, missing the description.

If you have linked your itemtypes to icons, the icon will still show.
Comment 1 Mark Hofstetter 2023-03-28 13:28:41 UTC
found the error submit patch soon
Comment 2 Mark Hofstetter 2023-03-28 13:53:37 UTC
Created attachment 148823 [details] [review]
Bug 33299: Item type column displays translated_description  when placing item level holds in OPAC

0. go to detail page of a record->place hold->"show more options"->"specific item"
1. Item type column is empty when placing item level holds in OPAC
(or only the image is displayed)
2. apply patch
3. now the translated description is also shown
4. test with another language
4. please sign off ;-)
Comment 3 PTFS Europe Sandboxes 2023-03-31 07:39:14 UTC
Created attachment 149013 [details] [review]
Bug 33299: Item type column displays translated_description when placing item level holds in OPAC

0. go to detail page of a record->place hold->"show more options"->"specific item"
1. Item type column is empty when placing item level holds in OPAC
(or only the image is displayed)
2. apply patch
3. now the translated description is also shown
4. test with another language
4. please sign off ;-)

Signed-off-by: Amaury Gau <amaury.gau@bulac.fr>
Comment 4 Nick Clemens 2023-04-01 23:32:43 UTC
Created attachment 149073 [details] [review]
Bug 33299: Item type column displays translated_description when placing item level holds in OPAC

0. go to detail page of a record->place hold->"show more options"->"specific item"
1. Item type column is empty when placing item level holds in OPAC
(or only the image is displayed)
2. apply patch
3. now the translated description is also shown
4. test with another language
4. please sign off ;-)

Signed-off-by: Amaury Gau <amaury.gau@bulac.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2023-04-06 12:52:38 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-04-16 20:38:00 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.