Bug 33306

Summary: Agreements list endpoint cannot embed user_roles
Product: Koha Reporter: Agustín Moyano <agustinmoyano>
Component: ERMAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED DUPLICATE QA Contact:
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, jonathan.field, martin.renvoize, pedro.amorim, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 33306: Add embed header parameter to agreements api definition

Description Agustín Moyano 2023-03-22 14:19:47 UTC
On bug 32924 the call to GET /api/v1/erm/agreements tries to embed user_roles, but from the API definition it is not allowed
Comment 1 Agustín Moyano 2023-03-22 14:28:54 UTC
Created attachment 148557 [details] [review]
Bug 33306: Add embed header parameter to agreements api definition

To test:
1. Enable ERMModule and add an agreement
2. When trying to list agreements, you should get an error
3. Apply patch
4. Error is now gone
Comment 2 Jonathan Druart 2023-03-22 14:41:57 UTC
It's on bug 32923 comment 36.

*** This bug has been marked as a duplicate of bug 32923 ***
Comment 3 Jonathan Druart 2023-03-23 14:06:23 UTC
I've just pushed it to master!