Summary: | Use template wrapper for tabs: Lists | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jacob.omara, sally.healey, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.05
|
|
Circulation function: | |||
Bug Depends on: | 32571 | ||
Bug Blocks: | |||
Attachments: |
Bug 33307: Use template wrapper for tabs: Lists
Bug 33307: Use template wrapper for tabs: Lists 5# Attachment to Bug 33307 - Use template wrapper for tabs: Lists |
Description
Owen Leonard
2023-03-22 15:36:08 UTC
Created attachment 148563 [details] [review] Bug 33307: Use template wrapper for tabs: Lists This patch updates the lists template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and go to the lists page in the staff interface. - Confirm that the two tabs, "Your lists" and "Public lists" look correct and work correctly. - Test that the correct tab is selected when you add the "public" or "private" parameter to the url: /cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=1 /cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=0 Created attachment 148594 [details] [review] Bug 33307: Use template wrapper for tabs: Lists This patch updates the lists template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and go to the lists page in the staff interface. - Confirm that the two tabs, "Your lists" and "Public lists" look correct and work correctly. - Test that the correct tab is selected when you add the "public" or "private" parameter to the url: /cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=1 /cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=0 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Works as described, thanks for the patch. Created attachment 149318 [details] [review] 5# Attachment to Bug 33307 - Use template wrapper for tabs: Lists Bug 33307: Use template wrapper for tabs: Lists This patch updates the lists template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and go to the lists page in the staff interface. - Confirm that the two tabs, "Your lists" and "Public lists" look correct and work correctly. - Test that the correct tab is selected when you add the "public" or "private" parameter to the url: /cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=1 /cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=0 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. |