| Summary: | x-marc-schema should be renamed x-record-schema | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | REST API | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart, lucas, martin.renvoize, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06
|
|
| Circulation function: | |||
| Bug Depends on: | 33227 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 33328: Rename x-marc-schema => x-record-schema
Bug 33328: Rename x-marc-schema => x-record-schema Bug 33328: Rename x-marc-schema => x-record-schema |
||
|
Description
Tomás Cohen Arazi (tcohen)
2023-03-23 22:29:11 UTC
Created attachment 148626 [details] [review] Bug 33328: Rename x-marc-schema => x-record-schema This patch renames the header on the biblio API so it is not entirely tied to MARC, trying to follow the biblio_metadata table generic approach. To test: 1. Apply this patch 2. Run: $ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass 3. You agree with the change? 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 149671 [details] [review] Bug 33328: Rename x-marc-schema => x-record-schema This patch renames the header on the biblio API so it is not entirely tied to MARC, trying to follow the biblio_metadata table generic approach. To test: 1. Apply this patch 2. Run: $ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass 3. You agree with the change? 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Magnus Enger <magnus@libriotech.no> Change sounds reasonable. Tests pass before and after patch. "grep -r "x-marc-schema" *" confirms no occurrences after patch. Created attachment 150500 [details] [review] Bug 33328: Rename x-marc-schema => x-record-schema This patch renames the header on the biblio API so it is not entirely tied to MARC, trying to follow the biblio_metadata table generic approach. To test: 1. Apply this patch 2. Run: $ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass 3. You agree with the change? 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Magnus Enger <magnus@libriotech.no> Change sounds reasonable. Tests pass before and after patch. "grep -r "x-marc-schema" *" confirms no occurrences after patch. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial improvement, Passing QA Pushed to master for 23.05. Nice work everyone, thanks! Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release Missing dependencies for 22.05.x, no backport. |