Summary: | Use template wrapper for tabs: SQL reports | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | alexandra.speer, jacob.omara, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.05
|
|
Circulation function: | |||
Bug Depends on: | 32571 | ||
Bug Blocks: | |||
Attachments: |
Bug 33333: Use template wrapper for tabs: SQL reports
Bug 33333: Use template wrapper for tabs: SQL reports Bug 33333: Use template wrapper for tabs: SQL reports |
Description
Owen Leonard
2023-03-24 17:16:32 UTC
Created attachment 148686 [details] [review] Bug 33333: Use template wrapper for tabs: SQL reports This patch updates the saved SQL reports template so that it uses the new WRAPPER directive to build tab markup. To test, apply the patch and go to Reports -> Use saved. In order to properly test the patch you should have multiple reports defined with multiple categories ("Accounts", "Acquisitions", "Catalog", etc.). Clicking each tab should filter the table of reports correctly. After navigating away from the page and back to it, your selected tab should be remembered. Created attachment 148756 [details] [review] Bug 33333: Use template wrapper for tabs: SQL reports This patch updates the saved SQL reports template so that it uses the new WRAPPER directive to build tab markup. To test, apply the patch and go to Reports -> Use saved. In order to properly test the patch you should have multiple reports defined with multiple categories ("Accounts", "Acquisitions", "Catalog", etc.). Clicking each tab should filter the table of reports correctly. After navigating away from the page and back to it, your selected tab should be remembered. Signed-off-by: Alexandra Speer <alexandra.speer@bsz-bw.de> Created attachment 149314 [details] [review] Bug 33333: Use template wrapper for tabs: SQL reports This patch updates the saved SQL reports template so that it uses the new WRAPPER directive to build tab markup. To test, apply the patch and go to Reports -> Use saved. In order to properly test the patch you should have multiple reports defined with multiple categories ("Accounts", "Acquisitions", "Catalog", etc.). Clicking each tab should filter the table of reports correctly. After navigating away from the page and back to it, your selected tab should be remembered. Signed-off-by: Alexandra Speer <alexandra.speer@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. |