| Summary: | Fix framework handling in manage-marc-import.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Gustafsson <glasklas> |
| Component: | Cataloging | Assignee: | David Gustafsson <glasklas> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | andreas.jonsson, david, m.de.rooy, mengu, nick, phil, stefan.berndtsson |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 33342: Assigment in if clause sets invalid marc framework
Bug 33342: Fix framework handling in manage-marc-import.pl |
||
|
Description
David Gustafsson
2023-03-27 13:03:19 UTC
Created attachment 148766 [details] [review] Bug 33342: Assigment in if clause sets invalid marc framework In a follow up in bug 15869 an if clause is added where "=" is used instead of "eq" in effect setting an invalid marc famework for the record. Fix this by using the correct operator. Obviously, the intention must be comparison; not assignment. But I don't see how this can introduce an invalid framework code. When I test the parameter "overlay_framework" is simply ignored. The expression $overlay_framework = '_USE_ORIG' should evaluate to TRUE, so the body of the if-statement, $overlay_framework = undef, should always be executed. Also, in manage-marc-import.tt the option name seems to have an underscore at the end as well: <option value="_USE_ORIG_">Keep original framework</option> So, only replacing assignment with comparison operator actually introduces the incorrect framework codes. We also need to fix the code value. Yes, of course. Thanks for that. That explains things (from the other perspective). I think our experience (having received "_USE"-frameworkcodes in the database) comes from us fixing the comparison, but not the dropdown, so now when the comparison works properly, it gets the wrong value, as you say. This patch should be updated before going forward. Setting it to "In Discussion" until it is properly fixed. Created attachment 148822 [details] [review] Bug 33342: Fix framework handling in manage-marc-import.pl In a follow up in bug 15869 an if clause is added where "=" is used instead of "eq" resulting in framwork always being set to undef. Fix this by using the correct operator. Also fix the name of the framework placeholder in manage-marc-import.pl which differed from the template. @Andreas Jonsson, thanks for spotting this! Have now fixed the patch and changed the description as the previous one did not correctly describe the current behavior. Since the assignment evaluates to true in a boolean context $overlay_framework as far as I can tell is always set to undef (which should now be fixed). If you could add a test plan, I would be more than happy to test. *** Bug 33692 has been marked as a duplicate of this bug. *** |