|
Description
Pedro Amorim
2023-03-29 08:26:30 UTC
Created attachment 148931 [details] [review] Bug 33354: Add 'required' UI elements Created attachment 148932 [details] [review] Bug 33354: Add error if related user open but user is missing Created attachment 148933 [details] [review] Bug 33354: Show all form error messages in the warning dialog Created attachment 149113 [details] [review] Bug 33354: Add 'required' UI elements Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 149114 [details] [review] Bug 33354: Add error if related user open but user is missing Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 149115 [details] [review] Bug 33354: Show all form error messages in the warning dialog Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 149854 [details] [review] Bug 33354: Add 'required' UI elements Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 149855 [details] [review] Bug 33354: Add error if related user open but user is missing Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 149856 [details] [review] Bug 33354: Show all form error messages in the warning dialog Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Reasonable solution, Passing QA. I'd like to have seen a corresponding cyrpess test, but after a quick discussion with Pedro I understand there's a medium term plan to look at migrating this from new window to modal operation and then write the tests there.. writing new window tests is beyond scope here (and isn't trivial apparently) Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Missing dependencies for 22.05.x, no backport. |