Summary: | Do not use editorconfig for vue files | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED INVALID | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | paul.derscheid, pedro.amorim, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 12545 | ||
Bug Blocks: | |||
Attachments: |
Bug 33358: Do not use .editorconfig for vue files
Bug 33358: Do not use .editorconfig for vue files |
Description
Jonathan Druart
2023-03-29 14:55:31 UTC
Created attachment 148929 [details] [review] Bug 33358: Do not use .editorconfig for vue files Using vscodium I noticed that the settings set in the editor were not used (for instance to not add semi colons at the end of the lines). This is because they get ignored when a .editorconfig exists. I didn't find the syntax "all but vue files", but it would be better than listing the different extensions. Paul, Pedro, can you help with this one please? Created attachment 150654 [details] [review] Bug 33358: Do not use .editorconfig for vue files I looked at the docs for editorconfig and I think I found the right syntax to achieve what we want. Correct me, if I'm wrong. To test: 1. Try this pattern on every filetype we use. 2. Assert it respects the rules. 3. Sign off. This patch does not work for me, using vscodium. I finally found what caused the original problem (vscodium not taking into account its own config). There is a "Prettier: Use Editor Config" that was set. I removed it and now it's working without any changes in Koha. I think that's the best solution for now, as nobody else seems to have problems. Closing. Another solution would be to have our prettier options defined in a .prettierrc. For ts, vue and js files. I really like the idea of a prettierrc file. Let's do it. |