| Summary: | virtualshelfcontents.flags seems useless | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> | 
| Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> | 
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> | 
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy, tomascohen | 
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | This patch set drops the column virtualshelfcontents.flag which is unused for a long time. | |
| Version(s) released in: | 23.11.00 | Circulation function: | |
| Attachments: | Bug 33379: Remove virtualshelfcontents.flags Bug 33379: DBIx changes Bug 33379: Remove virtualshelfcontents.flags Bug 33379: DBIx changes Bug 33379: Remove virtualshelfcontents.flags Bug 33379: DBIx changes Bug 33379: (QA follow-up) Tidy dbrev | ||
| 
        
          Description
        
        
          Jonathan Druart
        
        
        
        
          2023-03-31 07:53:09 UTC
        
       Created attachment 152749 [details] [review] Bug 33379: Remove virtualshelfcontents.flags This field is unused. A historic leftover from 2000-2010. Test plan: Run dbrev. Run prove t/db_dependent/Koha/Virtualshel* Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 152750 [details] [review] Bug 33379: DBIx changes Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 152770 [details] [review] Bug 33379: Remove virtualshelfcontents.flags This field is unused. A historic leftover from 2000-2010. Test plan: Run dbrev. Run prove t/db_dependent/Koha/Virtualshel* Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 152771 [details] [review] Bug 33379: DBIx changes Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 153010 [details] [review] Bug 33379: Remove virtualshelfcontents.flags This field is unused. A historic leftover from 2000-2010. Test plan: Run dbrev. Run prove t/db_dependent/Koha/Virtualshel* Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 153011 [details] [review] Bug 33379: DBIx changes Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> We could test if the column is empty, but this leads to problem in the past. I am in favor of dropping the column. There are release notes and backups to prevent data loss. Tomas: Any reason why this did not get further ? Please note that the perl tidy stuff started just now. This passed the former qa tools.. Created attachment 153718 [details] [review] Bug 33379: (QA follow-up) Tidy dbrev Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> OK Koha/Schema/Result/Virtualshelfcontent.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK tidiness OK valid OK installer/data/mysql/atomicupdate/bug33379.pl OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling OK tidiness OK valid OK installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation OK tinyint_has_boolean_flag Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |