| Summary: | Use template wrapper for breadcrumbs: Patrons part 4 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | andrew.auld, lucas, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06
|
|
| Circulation function: | |||
| Bug Depends on: | 32507 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4
Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4 Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4 Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4 |
||
|
Description
Owen Leonard
2023-03-31 16:36:21 UTC
Created attachment 149126 [details] [review] Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4 This patch updates several patron templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Patrons -> - Patron details - Notices - Accounting - Edit patron - Add patron - Patrons requesting modification (submit patron update via the OPAC) On members/moremember.tt the link in the breadcrumbs is missing the borrowernumber and results in a "Patron not found". - <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber | uri %]"> + <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% patron.borrowernumber | uri %]"> Created attachment 149275 [details] [review] Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4 This patch updates several patron templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Patrons -> - Patron details - Notices - Accounting - Edit patron - Add patron - Patrons requesting modification (submit patron update via the OPAC) Patron details link not working: /members/moremember.pl?borrowernumber=# (In reply to Andrew Auld from comment #4) > Patron details link not working: > /members/moremember.pl?borrowernumber=# This looks to me like it is working. Could you re-test? Created attachment 149600 [details] [review] Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4 This patch updates several patron templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Patrons -> - Patron details - Notices - Accounting - Edit patron - Add patron - Patrons requesting modification (submit patron update via the OPAC) Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> This is now signed off. However I did spot an alignment issue on the Update Patron Records page for which I have created a new bug number #33520. Created attachment 149992 [details] [review] Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4 This patch updates several patron templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Patrons -> - Patron details - Notices - Accounting - Edit patron - Add patron - Patrons requesting modification (submit patron update via the OPAC) Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. |