|
Description
Catrina Berka
2023-03-31 17:29:16 UTC
Created attachment 149109 [details] [review] Bug 33390: Add links to various system preference descriptions To test: 1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense: DefaultLongOverdueChargeValue DefaultLongOverdueLostValue and DefaultLongOverdueDays DefaultLongOverdueSkipLostStatuses UpdateItemWhenLostFromHoldList NewItemsDefaultLocation UpdateItemLocationOnCheckin SkipHoldTrapOnNotForLoanValue UpdateNotForLoanStatusOnCheckin Reference_NFL_Statuses ItemsDeniedRenewal Created attachment 149110 [details] [review] Bug 33390: Add links to various system preference descriptions To test: 1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense: DefaultLongOverdueChargeValue DefaultLongOverdueLostValue and DefaultLongOverdueDays DefaultLongOverdueSkipLostStatuses UpdateItemWhenLostFromHoldList NewItemsDefaultLocation UpdateItemLocationOnCheckin SkipHoldTrapOnNotForLoanValue UpdateNotForLoanStatusOnCheckin Reference_NFL_Statuses ItemsDeniedRenewal Signed-off-by: Catrina <catrina@bywatersolutions.com> Thank you, Lucas! This is exactly right and the patch works as expected. Hi Catrina. To complete the sign off, you need to change the status from "Needs Signoff" to "Signed Off". Then you will get the credit on the dashboard (https://dashboard.koha-community.org/). 8-) David I appreciate your help, David! Just changed it. Looking at this and as I won't finish right now, leaving a first note: ItemsDeniedRenewal: I feel the placement of the links right after the examples you can copy and paste is not ideal. Maybe we could put them into an explanatory sentence below? Created attachment 150178 [details] [review] Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place (In reply to Katrin Fischer from comment #6) > Looking at this and as I won't finish right now, leaving a first note: > > ItemsDeniedRenewal: I feel the placement of the links right after the > examples you can copy and paste is not ideal. Maybe we could put them into > an explanatory sentence below? I attached a follow-up to move those links. Let me know if you think that is better! Created attachment 150909 [details] [review] Bug 33390: Add links to various system preference descriptions To test: 1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense: DefaultLongOverdueChargeValue DefaultLongOverdueLostValue and DefaultLongOverdueDays DefaultLongOverdueSkipLostStatuses UpdateItemWhenLostFromHoldList NewItemsDefaultLocation UpdateItemLocationOnCheckin SkipHoldTrapOnNotForLoanValue UpdateNotForLoanStatusOnCheckin Reference_NFL_Statuses ItemsDeniedRenewal Signed-off-by: Catrina <catrina@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 150910 [details] [review] Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 150911 [details] [review] Bug 33390: (QA follow-up) Rephrase some preferences * to include 'authorised value' in text * to keep sentences on one line (translation) * to use sentences instead of just links in some places Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I tried to provide some more context in a few spots. Lucas, if you hate it, please feel free to obsolete :) (In reply to Katrin Fischer from comment #12) > I tried to provide some more context in a few spots. Lucas, if you hate it, > please feel free to obsolete :) It looks great to me!! Thanks for the follow-ups! Created attachment 158191 [details] [review] Bug 33390: Add links to various system preference descriptions To test: 1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense: DefaultLongOverdueChargeValue DefaultLongOverdueLostValue and DefaultLongOverdueDays DefaultLongOverdueSkipLostStatuses UpdateItemWhenLostFromHoldList NewItemsDefaultLocation UpdateItemLocationOnCheckin SkipHoldTrapOnNotForLoanValue UpdateNotForLoanStatusOnCheckin Reference_NFL_Statuses ItemsDeniedRenewal Signed-off-by: Catrina <catrina@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158192 [details] [review] Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158193 [details] [review] Bug 33390: (QA follow-up) Rephrase some preferences * to include 'authorised value' in text * to keep sentences on one line (translation) * to use sentences instead of just links in some places Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Rebased for current master and reset to 'Signed-off' Created attachment 158200 [details] [review] Bug 33390: Add links to various system preference descriptions To test: 1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense: DefaultLongOverdueChargeValue DefaultLongOverdueLostValue and DefaultLongOverdueDays DefaultLongOverdueSkipLostStatuses UpdateItemWhenLostFromHoldList NewItemsDefaultLocation UpdateItemLocationOnCheckin SkipHoldTrapOnNotForLoanValue UpdateNotForLoanStatusOnCheckin Reference_NFL_Statuses ItemsDeniedRenewal Signed-off-by: Catrina <catrina@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158201 [details] [review] Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158202 [details] [review] Bug 33390: (QA follow-up) Rephrase some preferences * to include 'authorised value' in text * to keep sentences on one line (translation) * to use sentences instead of just links in some places Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Not backported to avoid translation work. |