| Summary: | ERM Cypress tests needs to be moved to their own directory | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | dcook, lucas, martin.renvoize, matt.blenkinsop, victor |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.06
|
|
| Circulation function: | |||
| Bug Depends on: | 32030, 33370 | ||
| Bug Blocks: | 33408 | ||
| Attachments: |
Bug 33402: Move ERM Cypress tests to their own directory
Bug 33402: Move ERM Cypress tests to their own directory Bug 33402: Move ERM Cypress tests to their own directory Bug 33402: Move ERM Cypress tests to their own directory Bug 33402: (follow-up) Move Searchbar_spec.ts |
||
|
Description
Jonathan Druart
2023-04-04 11:26:43 UTC
Created attachment 149125 [details] [review] Bug 33402: Move ERM Cypress tests to their own directory We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts ) to their own subdirectory, eg t/cypress/integration/ERM Test plan: Confirm that the cypress tests are still passing after this change: perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only Created attachment 149192 [details] [review] Bug 33402: Move ERM Cypress tests to their own directory We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts ) to their own subdirectory, eg t/cypress/integration/ERM Test plan: Confirm that the cypress tests are still passing after this change: perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 149336 [details] [review] Bug 33402: Move ERM Cypress tests to their own directory We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts ) to their own subdirectory, eg t/cypress/integration/ERM Test plan: Confirm that the cypress tests are still passing after this change: perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works[1], makes sense, QA script happy, code looks good, passing QA :) [1] with and without the patch, I got the same consistent failures of Licenses_spec.ts and random failures in other files. btw, is the CI running them? I couldn't find cypress output in the last builds. (In reply to Victor Grousset/tuxayo from comment #4) > btw, is the CI running them They are run at the end if no other failure happened. Pushed to master for 23.05. Nice work everyone, thanks! Created attachment 149534 [details] [review] Bug 33402: Move ERM Cypress tests to their own directory We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts ) to their own subdirectory, eg t/cypress/integration/ERM Test plan: Confirm that the cypress tests are still passing after this change: perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Doh.. my bad.. I missed that Victor had already QA'd.. All good.. it's been pushed too now. It's missing a test file that has been created in the meanwhile. git mv t/cypress/integration/Searchbar_spec.ts t/cypress/integration/ERM/Searchbar_spec.ts Created attachment 149553 [details] [review] Bug 33402: (follow-up) Move Searchbar_spec.ts Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (In reply to Jonathan Druart from comment #5) > (In reply to Victor Grousset/tuxayo from comment #4) > > btw, is the CI running them > > They are run at the end if no other failure happened. ok! Not backporting as additional_work_needed flag is active and this is dependent on 33408 which has not been backported Not changing status to RESOLVED FIXED - is the additional_work_needed flag still required now that Searchbar_spec.ts has been migrated? The dependency is the other way around.. 33408 depends upon this. I think the additional_work_needed is a red herring too at this point.. I'm sure Tomas has pushed the follow-up. Nice work, thanks everyone! Pushed to 22.11.x for the next release. Not needed for 22.05.x, no backport |