Bug 33421

Summary:	Filtering purchase suggestions by status does not work if All Libraries is selected
Product:	Koha	Reporter:	Emily Lamancusa (emlam) <emily.lamancusa>
Component:	Acquisitions	Assignee:	Jonathan Druart <jonathan.druart>
Status:	RESOLVED FIXED	QA Contact:	Marcel de Rooy <m.de.rooy>
Severity:	normal
Priority:	P5 - low	CC:	jonathan.druart, m.de.rooy, nick
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.05.00,22.11.07
Circulation function:
Attachments:	Bug 33421: Fix filtering suggestions by status Bug 33421: Fix filtering suggestions by status Bug 33421: Fix filtering suggestions by status

Description Emily Lamancusa (emlam) 2023-04-05 14:07:08 UTC

To reproduce:
1. In suggestion.pl in the staff client, select "Viewing suggestions for library: Any"
2. Using the "Suggestion information" filters on the left of the page, select a particular status to filter by and click "Go"

Result: When the page reloads, suggestions of all statuses are shown, regardless of the selected filter.
In 22.5.09, the drop-down to filter by Status also resets to "All" (although the URL parameter appears correct).
In 22.11 and master, the drop-down to filter by Status retains the selected value but the results are not filtered.

If you set the drop-down for "Viewing suggestions for library" to a particular library and try again to filter by status, it filters correctly.

Comment 1 Jonathan Druart 2023-05-10 10:21:05 UTC

Created attachment 150959 [details] [review]
Bug 33421: Fix filtering suggestions by status

If the display is by status and a specific status is selected in the
filter, the filter won't have any effects.

Test plan:
Create several suggestions, with different status, for different
libraries.
Use the "display by status" view and filter on a given status
=> Result must be relevant

Comment 2 Emily Lamancusa (emlam) 2023-05-11 13:03:39 UTC

Created attachment 151076 [details] [review]
Bug 33421: Fix filtering suggestions by status

If the display is by status and a specific status is selected in the
filter, the filter won't have any effects.

Test plan:
Create several suggestions, with different status, for different
libraries.
Use the "display by status" view and filter on a given status
=> Result must be relevant

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>

Comment 3 Marcel de Rooy 2023-05-17 13:53:50 UTC

Created attachment 151338 [details] [review]
Bug 33421: Fix filtering suggestions by status

If the display is by status and a specific status is selected in the
filter, the filter won't have any effects.

Test plan:
Create several suggestions, with different status, for different
libraries.
Use the "display by status" view and filter on a given status
=> Result must be relevant

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-05-18 14:04:39 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 5 Matt Blenkinsop 2023-06-08 16:43:14 UTC

Nice work everyone!

Pushed to stable for 22.11.x