| Summary: | Use template wrapper for breadcrumbs: Reports part 2 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | andrew.auld, david, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06
|
|
| Circulation function: | |||
| Bug Depends on: | 32507 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 33437: Use template wrapper for breadcrumbs: Reports part 2
Edit report breadcrumb error Run report breadcrumb error View report breadcrumb error Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 |
||
|
Description
Owen Leonard
2023-04-06 18:44:08 UTC
Created attachment 149764 [details] [review] Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Most circulated items - Report results - Items with no checkouts - Report results - Catalog statistics wizard - Report results - View dictionary - New definition (steps 1-5) - Saved reports - View report - New report - Edit report - Guided reports - Build a report - Steps 1 through 6 Hi Owen, I have found a couple of issues with this patch. Firstly, I can't test the 'Items with no checkouts' results page as I am getting an error on the sandbox when I hit 'Submit': CGI::Compile::ROOT::kohadevbox_koha_reports_catalogue_out_2epl::calculate(): DBI Exception: DBD::mysql::st execute failed: 'koha_bugs.items.barcode' isn't in GROUP BY at /kohadevbox/koha/reports/catalogue_out.pl line 51 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Secondly, under saved reports and in the guided reports wizard area, there are a number of pages where the breadcrumb doesn't show as it should I don't think. I have attached a number of screenshots to show what I mean. Steps 1 through 6 of the wizard are all fine. I think it is the 'edit report' screen, the 'run report' screen and the 'view report' screen that are not quite right. All other parts of the test plan work fine. I hope this is helpful. Created attachment 149809 [details]
Edit report breadcrumb error
Created attachment 149810 [details]
Run report breadcrumb error
Created attachment 149811 [details]
View report breadcrumb error
Created attachment 149867 [details] [review] Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Most circulated items - Report results - Items with no checkouts - Report results - Catalog statistics wizard - Report results - View dictionary - New definition (steps 1-5) - Saved reports - View report - New report - Edit report - Guided reports - Build a report - Steps 1 through 6 Hi Owen, I have tested the guided reports screens and the breadcrumbs now look and behave as they should. Thank you. I still can't run the 'Items with no checkouts' report to get to the results page. This may well be user error rather than anything to do with your patch. But it does mean I haven't been able to test the Report results page. (In reply to Andrew Auld from comment #7) > I still can't run the 'Items with no checkouts' report to get to the results > page. Ah right, sorry I didn't comment on that issue. That seems to be a bug related to strict_sql_modes and can't be worked around unless you have access to koha-conf.xml Created attachment 150171 [details] [review] Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Most circulated items - Report results - Items with no checkouts - Report results - Catalog statistics wizard - Report results - View dictionary - New definition (steps 1-5) - Saved reports - View report - New report - Edit report - Guided reports - Build a report - Steps 1 through 6 Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. To turn off the strict database mode: - Edit /etc/koha/sites/kohadev/koha-conf.xml - Change strict_sql_modes from 1 to 0 (is right near the end of the file): <strict_sql_modes>0</strict_sql_modes> - flush_memcached and restart_all Created attachment 150423 [details] [review] Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Most circulated items - Report results - Items with no checkouts - Report results - Catalog statistics wizard - Report results - View dictionary - New definition (steps 1-5) - Saved reports - View report - New report - Edit report - Guided reports - Build a report - Steps 1 through 6 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release |