Bug 33438

Summary: Use template wrapper for breadcrumbs: Reports part 3
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: minor    
Priority: P5 - low CC: andrew.auld, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Circulation function:
Bug Depends on: 32507    
Bug Blocks:    
Attachments: Bug 33438: Use template wrapper for breadcrumbs: Reports part 3
Bug 33438: Use template wrapper for breadcrumbs: Reports part 3
Bug 33438: Use template wrapper for breadcrumbs: Reports part 3

Description Owen Leonard 2023-04-06 18:47:10 UTC
To continue the process started by Bug 32507, this patch will update several more reports templates so that they use the new template wrapper for breadcrumbs.

 - reports/issues_avg_stats.tt
 - reports/issues_stats.tt
 - reports/itemslost.tt
 - reports/itemtypes.tt
Comment 1 Owen Leonard 2023-04-17 18:38:31 UTC
Created attachment 149768 [details] [review]
Bug 33438: Use template wrapper for breadcrumbs: Reports part 3

This patch updates several reports templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Reports ->
  - Average loan time
    - Results
  - Circulation statistics
    - Results
  - Lost items
    - Results
  - Catalog by item type
    - Results
Comment 2 PTFS Europe Sandboxes 2023-04-18 13:26:58 UTC
Created attachment 149806 [details] [review]
Bug 33438: Use template wrapper for breadcrumbs: Reports part 3

This patch updates several reports templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Reports ->
  - Average loan time
    - Results
  - Circulation statistics
    - Results
  - Lost items
    - Results
  - Catalog by item type
    - Results

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Andrew Auld 2023-04-18 13:28:44 UTC
Great job Owen, it all looks fine to me!
Comment 4 Katrin Fischer 2023-04-20 20:39:27 UTC
Created attachment 149991 [details] [review]
Bug 33438: Use template wrapper for breadcrumbs: Reports part 3

This patch updates several reports templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Reports ->
  - Average loan time
    - Results
  - Circulation statistics
    - Results
  - Lost items
    - Results
  - Catalog by item type
    - Results

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-04-21 13:37:40 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-05-10 12:54:48 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.