Summary: | A public list can be transferred to a staff member without list permissions | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | Lists | Assignee: | Laura Escamilla <Laura.escamilla> |
Status: | Pushed to stable --- | QA Contact: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
Severity: | normal | ||
Priority: | P5 - low | CC: | baptiste.wojtkowski, david, jzairo, Laura.escamilla, lucas, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the transfer of public lists to staff patrons that do not have list permissions - when attempting to transfer the list, and the staff member doesn't have list permissions, an error message is now shown. Previously, the list could be transferred and then be edited by the staff patron without list permissions.
|
|
Version(s) released in: |
25.11.00,25.05.01
|
Circulation function: | |
Attachments: |
Bug 33440: Added permission requirements to unauthorized_transfer
Bug 33440: Updated wording for unauthorized_transfer error message Bug 33440: Updated wording for unauthorized_transfer OPAC message Bug 33440: Tests Bug 33440: Added permission requirements to unauthorized_transfer Bug 33440: Updated wording for unauthorized_transfer error message Bug 33440: Updated wording for unauthorized_transfer OPAC message Bug 33440: Tests Bug 33440: Added permission requirements to unauthorized_transfer Bug 33440: Updated wording for unauthorized_transfer error message Bug 33440: Updated wording for unauthorized_transfer OPAC message Bug 33440: Tests |
Description
Kelly McElligott
2023-04-06 19:17:47 UTC
Created attachment 181299 [details] [review] Bug 33440: Added permission requirements to unauthorized_transfer Created attachment 181300 [details] [review] Bug 33440: Updated wording for unauthorized_transfer error message Created attachment 181301 [details] [review] Bug 33440: Updated wording for unauthorized_transfer OPAC message Created attachment 181302 [details] [review] Bug 33440: Tests Test Plan 1. Staff member A creates a public list. 2. Staff member A transfers this public list to another staff member (staff member b) without list permissions. 3. Staff Member B now has the ability to edit this public list and add/remove items from this list. 4. Apply the patch 5. Repeat steps 1 and 2. An error message should now appear stating that the “Transfer not allowed: You or the selected user do not have the required permissions.” 6. Provide the correct permissions to Staff Member B. Initiate the transfer again. The transfer should be successful. 7. Test these steps in the OPAC as well. 8. Prove t/db_dependent/Virtualshelves.t 9. Sign off and have a wonderful day! :D Created attachment 181315 [details] [review] Bug 33440: Added permission requirements to unauthorized_transfer Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 181316 [details] [review] Bug 33440: Updated wording for unauthorized_transfer error message Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 181317 [details] [review] Bug 33440: Updated wording for unauthorized_transfer OPAC message Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 181318 [details] [review] Bug 33440: Tests Test Plan 1. Staff member A creates a public list. 2. Staff member A transfers this public list to another staff member (staff member b) without list permissions. 3. Staff Member B now has the ability to edit this public list and add/remove items from this list. 4. Apply the patch 5. Repeat steps 1 and 2. An error message should now appear stating that the “Transfer not allowed: You or the selected user do not have the required permissions.” 6. Provide the correct permissions to Staff Member B. Initiate the transfer again. The transfer should be successful. 7. Test these steps in the OPAC as well. 8. Prove t/db_dependent/Virtualshelves.t 9. Sign off and have a wonderful day! :D Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 183058 [details] [review] Bug 33440: Added permission requirements to unauthorized_transfer Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Created attachment 183059 [details] [review] Bug 33440: Updated wording for unauthorized_transfer error message Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Created attachment 183060 [details] [review] Bug 33440: Updated wording for unauthorized_transfer OPAC message Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Created attachment 183061 [details] [review] Bug 33440: Tests Test Plan 1. Staff member A creates a public list. 2. Staff member A transfers this public list to another staff member (staff member b) without list permissions. 3. Staff Member B now has the ability to edit this public list and add/remove items from this list. 4. Apply the patch 5. Repeat steps 1 and 2. An error message should now appear stating that the “Transfer not allowed: You or the selected user do not have the required permissions.” 6. Provide the correct permissions to Staff Member B. Initiate the transfer again. The transfer should be successful. 7. Test these steps in the OPAC as well. 8. Prove t/db_dependent/Virtualshelves.t 9. Sign off and have a wonderful day! :D Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x for 25.05.03 I've attempted a release note. Please update if I haven't got this right. I've also changed the bug importance from an enhancement to a normal bug - it is something that is not working as it should, rather than an improvement. |