Summary: | 'Actions' column on plugins table should not be sortable | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Staff interface | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33730 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.05.00,22.11.07
|
Circulation function: | |
Attachments: |
Bug 33463: Remove sort for 'Actions' on the plugins table
Bug 33463: Remove sort for 'Actions' on the plugins table |
Description
Katrin Fischer
2023-04-09 12:08:31 UTC
Created attachment 151066 [details] [review] Bug 33463: Remove sort for 'Actions' on the plugins table Test plan: Go go the plugin admin page upload a plugin Notice that the "Actions" column is not longuer sortable Looks like there are much more occurrences. git grep 'Actions</th>'|grep -v NoSort We should fix them all. (In reply to Jonathan Druart from comment #2) > Looks like there are much more occurrences. > > git grep 'Actions</th>'|grep -v NoSort > > We should fix them all. I have checked a few and I think there is other mark-up there to prevent them from being sorted sometimes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt: <th class="noExport">Actions</th> Action column on vendor search is NOT sortable. koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt:<th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt: <th>Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt: <th class="noExport">Actions</th> Actions IS sortable. koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt: <th scope="col">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt: <th data-class-name="actions noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: <th scope="col">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt: <th data-class-name="actions noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/credit_types.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_accounts.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_ean_accounts.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt: <th data-class-name="actions noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt: <th data-class-name="actions noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt: <th class="noExport">Actions</th> Table is not sortable at all. koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt: <th>Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt: <th class="noExport">Actions</th> Table is not sortable at all. koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt: <th scope="col">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: <th class="noExport">Actions</th> Actions is NOT sortable. I feel this might be a nice excercise for maybe a newbiew/intro session as they require taking a closer look maybe? I feel we can still push this one. Created attachment 151174 [details] [review] Bug 33463: Remove sort for 'Actions' on the plugins table Test plan: Go go the plugin admin page upload a plugin Notice that the "Actions" column is not longuer sortable Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Filed: Bug 33730 - Action column should not be sortable Easy fix, excercising QAM super powers here: PQA Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to 22.11.x for next release |