Summary: | Inconsistencies with tables in opac-shelves.tmpl | ||
---|---|---|---|
Product: | Koha | Reporter: | Garry Collum <gcollum> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, cookie.wolfrom, gmcharlt, nengard, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Comparison of the private and public lists of lists.
Proposed change Proposed change, revised Proposed fix for 3.2.x |
Description
Chris Cormack
2010-05-21 01:09:24 UTC
Created attachment 2944 [details] [review] Proposed change Change to list contents view to make it consistent with search results My intention is to make the OPAC more consistent in the way it displays lists of items, whether it be in search results, lists, etc. This patch adds data to the list contents output and reformats it to that end. The other significant change is the removal of jQuery table sorting. Since list contents are both sorted and paginated on the server side. Adding a client-side sort to one page of many doesn't make sense. Other changes include: - Change "Your lists" to "Your private lists" - Remove "sort by" column because it seems unnecessary - Adding logic to control display of count (item or items rather than item(s) - Styling pagination bar and placing at the bottom of the page, consistent with other instances of pagination navigation Tried on the new patch submitted yesterday and it did not apply. Applying Fix for Bug 3347 - Inconsistencies with tables in opac-shelves.tmpl .dotest/patch:120: trailing whitespace. #toolbar { error: patch failed: koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tmpl:6 error: koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tmpl: patch does not apply Using index info to reconstruct a base tree... <stdin>:120: trailing whitespace. #toolbar { warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merged C4/VirtualShelves.pm Auto-merged koha-tmpl/opac-tmpl/prog/en/css/opac.css Auto-merged koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tmpl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tmpl Failed to merge in the changes. Patch failed at 0001. When you have resolved this problem run "git-am -i -3 --resolved". If you would prefer to skip this patch, instead run "git-am -i -3 --skip". nengard@debian:~/kohaclone$ Created attachment 2945 [details] [review] Proposed change, revised Pushed, please test Created attachment 2960 [details] [review] Proposed fix for 3.2.x This bug is mentioned in: Fix for Bug 3347 - Inconsistencies with tables in opac-shelves.tmpl http://lists.koha-community.org/pipermail/koha-patches/2011-January/013508.html Fix for Bug 3347 - Inconsistencies with tables in opac-shelves.tmpl http://lists.koha-community.org/pipermail/koha-patches/2011-January/013516.html Fix for Bug 3347 - Inconsistencies with tables in opac-shelves.tmpl http://lists.koha-community.org/pipermail/koha-patches/2011-January/013517.html Fix for Bug 3347 - Inconsistencies with tables in opac-shelves.tmpl http://lists.koha-community.org/pipermail/koha-patches/2011-January/013533.html Fix for Bug 3347 - Inconsistencies with tables in opac-shelves.tmpl http://lists.koha-community.org/pipermail/koha-patches/2011-January/013511.html Fix for Bug 3347 - Inconsistencies with tables in opac-shelves.tmpl http://lists.koha-community.org/pipermail/koha-patches/2011-January/013542.html |