Description
Jonathan Druart
2023-04-11 07:57:42 UTC
Created attachment 149415 [details] [review] Bug 33480: Improve vendor aliases display in dropdown list On bug 33103 we are adding the ability to filter vendors by aliases. To make it possible in the ERM module we are adding the alias list in the dropdown list. However it's not nicely displayed, especially if there are several entries. This patch suggests to display the aliases in a different line, and not for the selected option. To acchieve that we create a new Vue component FormSelectVendors. Test plan: Create several vendors, and add some aliases to them (keep one vendor without alias) Go to the ERM module go to the following page, search for vendors by aliases, save the form, and confirm that everything is nice and works correctly: * Add/edit an agreement * Add/edit a license * Add/edit a local package * Add a new package to a title (edit a title) Created attachment 149416 [details] [review] Bug 33480: Remove vendors when not needed Several components retrieve the vendor list from store but it's not needed in those components. Created attachment 149418 [details] [review] Bug 33480: Display aliases on different lines This last patch is supposed to add an indentation for the aliases but it does not work... Created attachment 154936 [details] [review] Bug 33480: Improve vendor aliases display in dropdown list On bug 33103 we are adding the ability to filter vendors by aliases. To make it possible in the ERM module we are adding the alias list in the dropdown list. However it's not nicely displayed, especially if there are several entries. This patch suggests to display the aliases in a different line, and not for the selected option. To acchieve that we create a new Vue component FormSelectVendors. Test plan: Create several vendors, and add some aliases to them (keep one vendor without alias) Go to the ERM module go to the following page, search for vendors by aliases, save the form, and confirm that everything is nice and works correctly: * Add/edit an agreement * Add/edit a license * Add/edit a local package * Add a new package to a title (edit a title) Created attachment 154937 [details] [review] Bug 33480: Remove vendors when not needed Several components retrieve the vendor list from store but it's not needed in those components. Before those patch: https://snipboard.io/vMatno.jpg After: https://snipboard.io/hoBVG0.jpg With the third patch (obsoleted now), "Display aliases on different lines", I was trying to have one alias by line, and add some indent (left margin). I think the display is improved anyway and we can go with it as it. Created attachment 154942 [details] [review] Bug 33480: Improve vendor aliases display in dropdown list On bug 33103 we are adding the ability to filter vendors by aliases. To make it possible in the ERM module we are adding the alias list in the dropdown list. However it's not nicely displayed, especially if there are several entries. This patch suggests to display the aliases in a different line, and not for the selected option. To acchieve that we create a new Vue component FormSelectVendors. Test plan: Create several vendors, and add some aliases to them (keep one vendor without alias) Go to the ERM module go to the following page, search for vendors by aliases, save the form, and confirm that everything is nice and works correctly: * Add/edit an agreement * Add/edit a license * Add/edit a local package * Add a new package to a title (edit a title) Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 154943 [details] [review] Bug 33480: Remove vendors when not needed Several components retrieve the vendor list from store but it's not needed in those components. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Should we also consider displaying the vendor aliases on the show and list pages or not needed? (In reply to Pedro Amorim from comment #10) > Should we also consider displaying the vendor aliases on the show and list > pages or not needed? In my understanding the aliases are there to easy searching vendors, not sure it makes sense to have them on the show/list views. Jonathan (Field), what do you think? I agree, not needed QA happy Created attachment 155277 [details] [review] Bug 33480: (QA follow-up) Add cypress tests: Add tests for vendor aliases Test plan: perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |