Summary: | Patron restriction types - Style missing for dialog messages | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | System Administration | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | gmcharlt, jacob.omara, lucas, sally.healey |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06
|
|
Circulation function: | |||
Bug Depends on: | 23681 | ||
Bug Blocks: | |||
Attachments: |
Bug 33549: Fix dialog box in patron restrictions
Bug 33549: Fix dialog box in patron restrictions Bug 33549: Fix dialog box in patron restrictions Bug 33549: Improve wording of dialog messages |
Description
Caroline Cyr La Rose
2023-04-17 20:01:43 UTC
Created attachment 149824 [details] [review] Bug 33549: Fix dialog box in patron restrictions To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'New restriction' 4. Enter a code and label 5. Click 'Save' --> 'Type added' at the top of the page is not styled 6. Apply patch 7. Try again, dialog is styled correctly Created attachment 149845 [details] [review] Bug 33549: Fix dialog box in patron restrictions To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'New restriction' 4. Enter a code and label 5. Click 'Save' --> 'Type added' at the top of the page is not styled 6. Apply patch 7. Try again, dialog is styled correctly Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Works as described, thanks for the patch. Created attachment 149996 [details] [review] Bug 33549: Fix dialog box in patron restrictions To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'New restriction' 4. Enter a code and label 5. Click 'Save' --> 'Type added' at the top of the page is not styled 6. Apply patch 7. Try again, dialog is styled correctly Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 149997 [details] [review] Bug 33549: Improve wording of dialog messages In terms of translations type can be a lot of things. Usually translations are easier with more context, so I've added restriction to the type :) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Not needed for 22.05.x, no backport. |