Bug 33549

Summary: Patron restriction types - Style missing for dialog messages
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: System AdministrationAssignee: Lucas Gass (lukeg) <lucas>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: trivial    
Priority: P5 - low CC: gmcharlt, jacob.omara, lucas, sally.healey
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Circulation function:
Bug Depends on: 23681    
Bug Blocks:    
Attachments: Bug 33549: Fix dialog box in patron restrictions
Bug 33549: Fix dialog box in patron restrictions
Bug 33549: Fix dialog box in patron restrictions
Bug 33549: Improve wording of dialog messages

Description Caroline Cyr La Rose 2023-04-17 20:01:43 UTC
When adding or deleting patron restriction types, the dialog messages ("Type added", "Type deleted", etc.) have no styling. Normally, such messages are on a blue background.

To test:
1. Enable PatronRestrictionTypes
2. Go to Administration > Patron restrictions
3. Click 'New restriction'
4. Enter a code and label
5. Click 'Save'
   --> 'Type added' at the top of the page is not styled

To see a regular dialog message:
1. Go to Administration > Debit types
2. Click 'New debit type'
3. Enter a code and description
4. Click 'Save'
   --> 'Debit type saved successfully' on blue background
Comment 1 Lucas Gass (lukeg) 2023-04-18 17:08:06 UTC
Created attachment 149824 [details] [review]
Bug 33549: Fix dialog box in patron restrictions

To test:
1. Enable PatronRestrictionTypes
2. Go to Administration > Patron restrictions
3. Click 'New restriction'
4. Enter a code and label
5. Click 'Save'
   --> 'Type added' at the top of the page is not styled
6. Apply patch
7. Try again, dialog is styled correctly
Comment 2 ByWater Sandboxes 2023-04-19 09:05:40 UTC
Created attachment 149845 [details] [review]
Bug 33549: Fix dialog box in patron restrictions

To test:
1. Enable PatronRestrictionTypes
2. Go to Administration > Patron restrictions
3. Click 'New restriction'
4. Enter a code and label
5. Click 'Save'
   --> 'Type added' at the top of the page is not styled
6. Apply patch
7. Try again, dialog is styled correctly

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Sally 2023-04-19 09:06:01 UTC
Works as described, thanks for the patch.
Comment 4 Katrin Fischer 2023-04-20 21:08:41 UTC
Created attachment 149996 [details] [review]
Bug 33549: Fix dialog box in patron restrictions

To test:
1. Enable PatronRestrictionTypes
2. Go to Administration > Patron restrictions
3. Click 'New restriction'
4. Enter a code and label
5. Click 'Save'
   --> 'Type added' at the top of the page is not styled
6. Apply patch
7. Try again, dialog is styled correctly

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-04-20 21:08:44 UTC
Created attachment 149997 [details] [review]
Bug 33549: Improve wording of dialog messages

In terms of translations type can be a lot of things.
Usually translations are easier with more context, so
I've added restriction to the type :)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-04-24 13:50:06 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-05-10 15:00:43 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 8 Lucas Gass (lukeg) 2023-05-15 21:30:03 UTC
Not needed for 22.05.x, no backport.