Bug 33555

Summary:	Use template wrapper for breadcrumbs: Rotating collections
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	RESOLVED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	testopia
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.05.00,22.11.06
Circulation function:
Bug Depends on:	32507
Bug Blocks:
Attachments:	Bug 33555: Use template wrapper for breadcrumbs: Rotating collections Bug 33555: Use template wrapper for breadcrumbs: Rotating collections Bug 33555: Use template wrapper for breadcrumbs: Rotating collections

Description Owen Leonard 2023-04-18 12:24:45 UTC

To continue the process started by Bug 32507, this patch will update rotating collections templates so that they use the new template wrapper for breadcrumbs.

 - rotating_collections/addItems.tt
 - rotating_collections/editCollections.tt
 - rotating_collections/rotatingCollections.tt
 - rotating_collections/transferCollection.tt

Comment 1 Owen Leonard 2023-04-18 12:38:56 UTC

Created attachment 149797 [details] [review]
Bug 33555: Use template wrapper for breadcrumbs: Rotating collections

This patch updates rotating collections templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Rotating collections
    - New rotating collection
    - Edit collection
    - Delete collection
    - Manage items
    - Transfer collection

Comment 2 Lucas Gass (lukeg) 2023-04-18 15:04:44 UTC

Created attachment 149819 [details] [review]
Bug 33555: Use template wrapper for breadcrumbs: Rotating collections

This patch updates rotating collections templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Rotating collections
    - New rotating collection
    - Edit collection
    - Delete collection
    - Manage items
    - Transfer collection

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Comment 3 Katrin Fischer 2023-04-20 20:33:36 UTC

Created attachment 149989 [details] [review]
Bug 33555: Use template wrapper for breadcrumbs: Rotating collections

This patch updates rotating collections templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Rotating collections
    - New rotating collection
    - Edit collection
    - Delete collection
    - Manage items
    - Transfer collection

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-04-21 13:37:48 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 5 Jacob O'Mara 2023-05-10 12:54:54 UTC

Nice work, thanks everyone!

Pushed to 22.11.x for the next release.