Bug 33558

Summary:	Use template wrapper for breadcrumbs: Serials part 1
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	RESOLVED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	testopia
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.05.00,22.11.06
Circulation function:
Bug Depends on:	32507
Bug Blocks:
Attachments:	Bug 33558: Use template wrapper for breadcrumbs: Serials part 1 Bug 33558: Use template wrapper for breadcrumbs: Serials part 1 Bug 33558: Use template wrapper for breadcrumbs: Serials part 1

Description Owen Leonard 2023-04-18 13:14:28 UTC

To continue the process started by Bug 32507, this patch will update several serials templates so that they use the new template wrapper for breadcrumbs.

 - serials/checkexpiration.tt
 - serials/claims.tt
 - serials/routing-preview.tt
 - serials/routing.tt
 - serials/serials-collection.tt

Comment 1 Owen Leonard 2023-04-18 15:07:48 UTC

Created attachment 149820 [details] [review]
Bug 33558: Use template wrapper for breadcrumbs: Serials part 1

This patch updates several serials templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Serials ->
  - Claims
    - Claims for a vendor
  - Check expiration
  - Subscription details ->
    - Serial collection
    - Create routing list
    - Edit routing list
    - Preview routing list

Comment 2 Matt Blenkinsop 2023-04-19 08:14:14 UTC

Created attachment 149844 [details] [review]
Bug 33558: Use template wrapper for breadcrumbs: Serials part 1

This patch updates several serials templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Serials ->
  - Claims
    - Claims for a vendor
  - Check expiration
  - Subscription details ->
    - Serial collection
    - Create routing list
    - Edit routing list
    - Preview routing list

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Comment 3 Katrin Fischer 2023-04-20 20:30:50 UTC

Created attachment 149988 [details] [review]
Bug 33558: Use template wrapper for breadcrumbs: Serials part 1

This patch updates several serials templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Serials ->
  - Claims
    - Claims for a vendor
  - Check expiration
  - Subscription details ->
    - Serial collection
    - Create routing list
    - Edit routing list
    - Preview routing list

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-04-21 13:37:51 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 5 Jacob O'Mara 2023-05-10 12:54:57 UTC

Nice work, thanks everyone!

Pushed to 22.11.x for the next release.