Bug 33572

Summary: Use template wrapper for breadcrumbs: Tools, part 3
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: minor    
Priority: P5 - low CC: barbara.johnson, testopia
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Circulation function:
Bug Depends on: 32507    
Bug Blocks:    
Attachments: Bug 33572: Use template wrapper for breadcrumbs: Tools, part 3
Bug 33572: Use template wrapper for breadcrumbs: Tools, part 3
Bug 33572: Use template wrapper for breadcrumbs: Tools, part 3

Description Owen Leonard 2023-04-20 13:30:15 UTC
To continue the process started by Bug 32507, this patch will update several more tools templates so that they use the new template wrapper for breadcrumbs.

- tools/csv-profiles.tt
- tools/export.tt
- tools/holidays.tt
- tools/import_borrowers.tt
- tools/inventory.tt
Comment 1 Owen Leonard 2023-04-21 12:02:31 UTC
Created attachment 150035 [details] [review]
Bug 33572: Use template wrapper for breadcrumbs: Tools, part 3

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - CSV profiles
    - New CSV profile
    - Edit CSV profile
  - Calendar
  - Import patrons
    - Results
- Cataloging ->
  - Export catalog data
  - Inventory
    - Results
Comment 2 ByWater Sandboxes 2023-04-21 14:48:54 UTC
Created attachment 150049 [details] [review]
Bug 33572: Use template wrapper for breadcrumbs: Tools, part 3

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - CSV profiles
    - New CSV profile
    - Edit CSV profile
  - Calendar
  - Import patrons
    - Results
- Cataloging ->
  - Export catalog data
  - Inventory
    - Results

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 Katrin Fischer 2023-04-21 20:05:09 UTC
Created attachment 150070 [details] [review]
Bug 33572: Use template wrapper for breadcrumbs: Tools, part 3

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - CSV profiles
    - New CSV profile
    - Edit CSV profile
  - Calendar
  - Import patrons
    - Results
- Cataloging ->
  - Export catalog data
  - Inventory
    - Results

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-04-24 13:50:20 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-05-10 12:55:06 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.