Bug 33577

Summary: Buttons on reserve/request.pl are misaligned
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: CirculationAssignee: Lucas Gass (lukeg) <lucas>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: barbara.johnson, gmcharlt, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Circulation function:
Attachments: Bug 33577: Add btn class to cancel hold button on /reserve/request.pl
Bug 33577: Add btn class to cancel hold button on /reserve/request.pl
Bug 33577: Add btn class to cancel hold button on /reserve/request.pl

Description Lucas Gass (lukeg) 2023-04-20 16:39:54 UTC
While working on Bug 33575 I noticed the Update hold and Cancel hold buttons are not quite the same size. 

One needs the cancel_selected_holds button needs the Bootstrap 'btn' class.
Comment 1 Lucas Gass (lukeg) 2023-04-20 16:44:04 UTC
Created attachment 149980 [details] [review]
Bug 33577: Add btn class to cancel hold button on /reserve/request.pl

To test:
1. Place a hold on a record and look at the /reserve/request.pl page.
2. Notice the two buttons 'Update hold(s)' and 'Cancel selected' buttons are not quite the same size.
3. Apply patch and look again, the buttons should line up.
Comment 2 ByWater Sandboxes 2023-04-21 01:21:02 UTC
Created attachment 149998 [details] [review]
Bug 33577: Add btn class to cancel hold button on /reserve/request.pl

To test:
1. Place a hold on a record and look at the /reserve/request.pl page.
2. Notice the two buttons 'Update hold(s)' and 'Cancel selected' buttons are not quite the same size.
3. Apply patch and look again, the buttons should line up.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 Katrin Fischer 2023-04-22 13:30:45 UTC
Created attachment 150078 [details] [review]
Bug 33577: Add btn class to cancel hold button on /reserve/request.pl

To test:
1. Place a hold on a record and look at the /reserve/request.pl page.
2. Notice the two buttons 'Update hold(s)' and 'Cancel selected' buttons are not quite the same size.
3. Apply patch and look again, the buttons should line up.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-04-24 13:50:24 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-05-10 15:00:47 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 6 Lucas Gass (lukeg) 2023-05-15 21:20:19 UTC
Not needed in 22.05.x, no backport