| Summary: | Get rid of few SameSite warnings | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Templates | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | lucas, nick |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06,22.05.13
|
|
| Circulation function: | |||
| Attachments: |
Bug 33597: Get rid of warning about intranet_bib_list
Bug 33597: Fix deleting cookie for holdfor(club) Bug 33597: (follow-up) Two other occurrences for holdfor Bug 33597: (follow-up) Two other occurrences for holdfor Bug 33597: Get rid of warning about intranet_bib_list Bug 33597: Fix deleting cookie for holdfor(club) Bug 33597: (follow-up) Two other occurrences for holdfor |
||
|
Description
Marcel de Rooy
2023-04-24 10:24:48 UTC
Created attachment 150148 [details] [review] Bug 33597: Get rid of warning about intranet_bib_list Resolve: Cookie “intranet_bib_list” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. basket_22.1200022.js:67:65 Test plan: Do not apply this patch. Logout from staff. Check browser console warnings. Apply this patch. Login and logout again. Check warnings again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 150149 [details] [review] Bug 33597: Fix deleting cookie for holdfor(club) Resolve: Cookie “holdfor” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. Did not see warning for holdforclub. But since it is created with Lax, we should remove it with Lax. Test plan: Similar to previous patch. Check console on logout page. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Trivial patches: self SO Created attachment 150150 [details] [review] Bug 33597: (follow-up) Two other occurrences for holdfor Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 150151 [details] [review] Bug 33597: (follow-up) Two other occurrences for holdfor Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 150413 [details] [review] Bug 33597: Get rid of warning about intranet_bib_list Resolve: Cookie “intranet_bib_list” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. basket_22.1200022.js:67:65 Test plan: Do not apply this patch. Logout from staff. Check browser console warnings. Apply this patch. Login and logout again. Check warnings again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 150414 [details] [review] Bug 33597: Fix deleting cookie for holdfor(club) Resolve: Cookie “holdfor” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. Did not see warning for holdforclub. But since it is created with Lax, we should remove it with Lax. Test plan: Similar to previous patch. Check console on logout page. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 150415 [details] [review] Bug 33597: (follow-up) Two other occurrences for holdfor Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> I still noted 6 warnings about this, but we don't need to do them all at once :) (In reply to Nick Clemens from comment #8) > Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Thx Nick Pushed to master for 23.05. Nice work everyone, thanks! Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release Backported to 22.05.x for upcoming 22.05.13 |