Description
Nick Clemens
2023-04-25 13:27:11 UTC
Created attachment 150212 [details] [review] Bug 33607: Add framework display to staff details page This patch adds a Frameworks pluing to allow fetching the framework text and displays this on the intranet details page To test: 1 - Apply patch 2 - View a record details page in staff 3 - Confirm you see the framework name 4 - prove -v t/db_dependent/Template/Plugin/Frameworks.t This is handy! I think the tests for Frameworks.t need to have permissions changed to -rwxrwxr-x . Also, is this something to be concerned about? FAIL Koha/Template/Plugin/Frameworks.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 Created attachment 150238 [details] [review] Bug 33607: Add framework display to staff details page This patch adds a Frameworks pluing to allow fetching the framework text and displays this on the intranet details page To test: 1 - Apply patch 2 - View a record details page in staff 3 - Confirm you see the framework name 4 - prove -v t/db_dependent/Template/Plugin/Frameworks.t Hey Nick, Can this take into account the default framework, which does not have a framworkcode? Created attachment 150574 [details] [review] Bug 33607: (follow-up) Handle default framework Created attachment 150578 [details] [review] Bug 33607: Add framework display to staff details page This patch adds a Frameworks pluing to allow fetching the framework text and displays this on the intranet details page To test: 1 - Apply patch 2 - View a record details page in staff 3 - Confirm you see the framework name 4 - prove -v t/db_dependent/Template/Plugin/Frameworks.t Signed-off-by: David Nind <david@davidnind.com> Created attachment 150579 [details] [review] Bug 33607: (follow-up) Handle default framework Signed-off-by: David Nind <david@davidnind.com> Created attachment 150836 [details] [review] [ALTERNATE PATCH] Bug 33607: Handle default framework What about this patch, Nick? (In reply to Jonathan Druart from comment #9) > What about this patch, Nick? Yes, that's better, I need to learn translation tools :-) Created attachment 150860 [details] [review] Bug 33607: Add framework display to staff details page This patch adds a Frameworks pluing to allow fetching the framework text and displays this on the intranet details page To test: 1 - Apply patch 2 - View a record details page in staff 3 - Confirm you see the framework name 4 - prove -v t/db_dependent/Template/Plugin/Frameworks.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 150861 [details] [review] Bug 33607: Handle default framework Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.05. Nice work everyone, thanks! Enhancement - not backporting to 22.11.x |