| Summary: | Don't show patron-privacyguarantor/patron-privacy_guarantor_fines if borrowerRelationship is empty | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Patrons | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall, m.de.rooy, sally.healey |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty
Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty |
||
|
Description
Lucas Gass (lukeg)
2023-04-26 20:54:46 UTC
Created attachment 150257 [details] [review] Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty To test: 1. Apply patch 2. Have some values in borrowerRelationship. 3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:' 4. Now empty borrowerRelationship. 5. Visit the patron detail page again and you should no longer see either of those fields. Created attachment 150297 [details] [review] Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty To test: 1. Apply patch 2. Have some values in borrowerRelationship. 3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:' 4. Now empty borrowerRelationship. 5. Visit the patron detail page again and you should no longer see either of those fields. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Works as described, thanks for the patch. Created attachment 153188 [details] [review] Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty To test: 1. Apply patch 2. Have some values in borrowerRelationship. 3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:' 4. Now empty borrowerRelationship. 5. Visit the patron detail page again and you should no longer see either of those fields. (In reply to Sally from comment #3) > Works as described, thanks for the patch. You forgot your signoff line, Sally. Created attachment 155654 [details] [review] Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty To test: 1. Apply patch 2. Have some values in borrowerRelationship. 3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:' 4. Now empty borrowerRelationship. 5. Visit the patron detail page again and you should no longer see either of those fields. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Marcel de Rooy from comment #5) > (In reply to Sally from comment #3) > > Works as described, thanks for the patch. > > You forgot your signoff line, Sally. I don't think I did? I signed off on a sandbox. You can see my sign off line on comment #2: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620#c2 It looks like Lucas updated the patch again after my sign off in comments 2 and 3, and added a new patch on comment 4 a few months later? Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |