Summary: | Notice content does not show on default tab if TranslateNotices enabled | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Notices | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, lucas, oleonard |
Version: | Main | Keywords: | rel_22_11_candidate |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06
|
|
Circulation function: | |||
Bug Depends on: | 32912 | ||
Bug Blocks: | |||
Attachments: |
Bug 33622: Notice content does not show on default tab if TranslateNotices enabled
Bug 33622: Notice content does not show on default tab if TranslateNotices enabled Bug 33622: Notice content does not show on default tab if TranslateNotices enabled |
Description
Aleisha Amohia
2023-04-27 01:06:47 UTC
Also confirmed in master. Wonder if this could have something to do with the work on tabs? Adding Owen. (I'm using main in place of master as much as possible hehe) You are right - I think we also decided to switch, but haven't yet figured out the steps and timing. I mostly wanted to help this along saying I can see it too and I'd also really like to see it fixed - it could cause a bit of a panic when people think they lost their content. I just checked our 22.11.03 instance and it still appears to be working ok there. Maybe another clue. Bug 32912 could be a possible candidate. Created attachment 150529 [details] [review] Bug 33622: Notice content does not show on default tab if TranslateNotices enabled This patch fixes a conflict between the template-generated markup and Bootstrap JS which were both competing to show the correct default tab. It's simpler to rely on JavaScript. To test, apply the patch and enable the TranslateNotices system preference if necessary. - Go to Tools -> Notices & slips - Go to edit any notice e.g. DUEDGST - The page should load with the "Default" tab selected by default. - Enter unique titles and contents under each tab to confirm that the data you see under the "Default" or "English (en)" tab is being shown in the right place. - Save your modified notice and edit it again to confirm that the tabs correspond correctly to your data. Created attachment 150533 [details] [review] Bug 33622: Notice content does not show on default tab if TranslateNotices enabled This patch fixes a conflict between the template-generated markup and Bootstrap JS which were both competing to show the correct default tab. It's simpler to rely on JavaScript. To test, apply the patch and enable the TranslateNotices system preference if necessary. - Go to Tools -> Notices & slips - Go to edit any notice e.g. DUEDGST - The page should load with the "Default" tab selected by default. - Enter unique titles and contents under each tab to confirm that the data you see under the "Default" or "English (en)" tab is being shown in the right place. - Save your modified notice and edit it again to confirm that the tabs correspond correctly to your data. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. To replicate the issue (note: ACCOUNTS_SUMMARY has no email notice, DUEDGST does have an email notice) I had to install another language (other than just having the Default and English (en) tabs): - Install another language: koha-translate install fr-CA - Enable the language: Administration > System preferences > I18N/L10N > language > Français (fr-CA) - Enable the TranslateNotices system preference - Edit the DUEDGST notice - It opens on the Default tab: expand the Email notice --> it is blank - Click on the tabs for English (en) and Français (fr-CA), and expand the email notice section (should be blank, unless you've added translations already) - Click back on the Default tab and expand the Email notice --> it is now not blank - Refreshing the page resets things, so you can then replicate the issue again Created attachment 150535 [details] [review] Bug 33622: Notice content does not show on default tab if TranslateNotices enabled This patch fixes a conflict between the template-generated markup and Bootstrap JS which were both competing to show the correct default tab. It's simpler to rely on JavaScript. To test, apply the patch and enable the TranslateNotices system preference if necessary. - Go to Tools -> Notices & slips - Go to edit any notice e.g. DUEDGST - The page should load with the "Default" tab selected by default. - Enter unique titles and contents under each tab to confirm that the data you see under the "Default" or "English (en)" tab is being shown in the right place. - Save your modified notice and edit it again to confirm that the tabs correspond correctly to your data. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Missing dependencies for 22.05.x, no backport. |