| Summary: | results_summary label and content are slightly misaligned in staff interface | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Staff interface | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | david, dcook, gmcharlt, m.de.rooy |
| Version: | Main | Keywords: | rel_22_11_candidate |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06
|
|
| Circulation function: | |||
| Attachments: |
Bug 33631: Fix alignment issue in results_summary
Bug 33631: Fix alignment issue in results_summary Bug 33631: [alternate] Fix misaligned labels k Bug 33631: [alternate] Fix misaligned labels Bug 33631: [alternate] Fix misaligned labels |
||
|
Description
Lucas Gass (lukeg)
2023-04-27 15:15:54 UTC
Created attachment 150307 [details] [review] Bug 33631: Fix alignment issue in results_summary To test: 1 On staff results or detail page notice that slight misaligmnet between label and content. 2. Apply patch, yarn_build, clear browser cache 3. Look again, alignment should be fixed Created attachment 150314 [details] [review] Bug 33631: Fix alignment issue in results_summary To test: 1 On staff results or detail page notice that slight misaligmnet between label and content. 2. Apply patch, yarn_build, clear browser cache 3. Look again, alignment should be fixed Signed-off-by: David Nind <david@davidnind.com> Thanks Lucas for reporting and fixing this! I also noticed some ISBD view labels are slightly misaligned (see for example biblionumber=262 Programming Perl). I can log a separate bug for this if you like. (In reply to David Nind from comment #3) > Thanks Lucas for reporting and fixing this! > > I also noticed some ISBD view labels are slightly misaligned (see for > example biblionumber=262 Programming Perl). I can log a separate bug for > this if you like. David, I am going to provide an alternative patch that will fix both. I think we can eliminate the vertical-align rule altogether. It will effect all label (element) and .label ( class ) in Koha so it will require a bit more thourough testing. Created attachment 150320 [details] [review] Bug 33631: [alternate] Fix misaligned labels (In reply to Lucas Gass from comment #4) > (In reply to David Nind from comment #3) > > Thanks Lucas for reporting and fixing this! > > > > I also noticed some ISBD view labels are slightly misaligned (see for > > example biblionumber=262 Programming Perl). I can log a separate bug for > > this if you like. > > David, > > I am going to provide an alternative patch that will fix both. I think we > can eliminate the vertical-align rule altogether. It will effect all label > (element) and .label ( class ) in Koha so it will require a bit more > thourough testing. Back to NSO for such testing :) We've also seen this - happy to have a look! Created attachment 150453 [details] [review] k Created attachment 150454 [details] [review] Bug 33631: [alternate] Fix misaligned labels If you look at the results_summary on either the results or detail pages you will notice that the label and content are slightly misaligned. To test: 1. On staff results, detail page, or ISBD details notice that slight misaligmnet between label and content. 2. Apply patch, yarn_build, clear browser cache 3. Look again, alignment should be fixed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I've fixed the commit message :) Thanks for testing and signing off Katrin! (You beat me to it!) I was working through various screens, but had not found anything - so far, any misalignments I found were already there before the patch. This also now corrects the display in the search results. David Please sign-off, then I can use my token for QA :) Created attachment 150465 [details] [review] Bug 33631: [alternate] Fix misaligned labels If you look at the results_summary on either the results or detail pages you will notice that the label and content are slightly misaligned. To test: 1. On staff results, detail page, or ISBD details notice that slight misaligmnet between label and content. 2. Apply patch, yarn_build, clear browser cache 3. Look again, alignment should be fixed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> (In reply to Katrin Fischer from comment #12) > Please sign-off, then I can use my token for QA :) Done! I also tested a sample of other pages to see if I noticed any changes (this was in no way comprehensive). I only identified some minor misalignments that were present before the patch was applied. Pushed to master for 23.05. Nice work everyone, thanks! Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release |