Bug 33643

Summary: Add page-section to 'scan index' page
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Staff interfaceAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: gmcharlt, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Circulation function:
Bug Depends on: 33505    
Bug Blocks:    
Attachments: Bug 33643: Add page-section to 'scan index' page in staff interface
Bug 33643: Add page-section to 'scan index' page in staff interface
Bug 33643: Add page-section to 'scan index' page in staff interface

Description Katrin Fischer 2023-05-01 13:22:21 UTC

    
Comment 1 Katrin Fischer 2023-05-01 13:29:09 UTC
Created attachment 150452 [details] [review]
Bug 33643: Add page-section to 'scan index' page in staff interface

This adds the white background. As we do on other pages I have
chosen to include the h2 heading within the page-section.

To test:
* Go to advanced search in staff interface
* Activate 'More options'
* Check checkbox for scan indexes
* Switch to author (especially when using Elasticsearch)
* Search for C
* On the result list verify there is no white background/page section
* Apply patch
* Repeat test - background should be present now
Comment 2 Lucas Gass (lukeg) 2023-05-01 16:31:35 UTC
Created attachment 150461 [details] [review]
Bug 33643: Add page-section to 'scan index' page in staff interface

This adds the white background. As we do on other pages I have
chosen to include the h2 heading within the page-section.

To test:
* Go to advanced search in staff interface
* Activate 'More options'
* Check checkbox for scan indexes
* Switch to author (especially when using Elasticsearch)
* Search for C
* On the result list verify there is no white background/page section
* Apply patch
* Repeat test - background should be present now

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Nicolas Giraud 2023-05-08 18:10:01 UTC
Created attachment 150805 [details] [review]
Bug 33643: Add page-section to 'scan index' page in staff interface

This adds the white background. As we do on other pages I have
chosen to include the h2 heading within the page-section.

To test:
* Go to advanced search in staff interface
* Activate 'More options'
* Check checkbox for scan indexes
* Switch to author (especially when using Elasticsearch)
* Search for C
* On the result list verify there is no white background/page section
* Apply patch
* Repeat test - background should be present now

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Nicolas Giraud <nicolas.giraud@inlibro.com>
Comment 4 Katrin Fischer 2023-05-08 21:11:04 UTC
Setting to PQA by counting Lucas for QA :)
Comment 5 Tomás Cohen Arazi (tcohen) 2023-05-09 13:52:01 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-05-15 10:10:09 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass (lukeg) 2023-06-15 14:52:52 UTC
Not needed in 22.05.x, no backport.