Summary: | Add ability to cancel order lines in closed baskets | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Acquisitions | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | RESOLVED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | acampbell, barbara.johnson, caroline.cyr-la-rose, fridolin.somers, katariina.hanhisalo, kyle, martin.renvoize, mathsabypro, michaela.sieber, nick, rkuiper |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28771 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 |
||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/813 |
Text to go in the release notes: |
With the new system preference `CancelOrdersInClosedBaskets` it's now possible to allow for cancelling order lines from closed baskets. This is useful if something cannot be delivered and you don't want to reopen the basket or use go through the receive shipment process.
**Sponsored by** *The Research University in the Helmholtz Association (KIT)*
|
Version(s) released in: |
23.11.00
|
Attachments: |
Bug 33664: Add ability to cancel order lines in closed baskets
Bug 33664: Add ability to cancel order lines in closed baskets Bug 33664: Add ability to cancel order lines in closed baskets Bug 33664: Add ability to cancel order lines in closed baskets Bug 33664: (follow-up) Move check for 'received' to include Modify link Bug 33664: Add ability to cancel order lines in closed baskets Bug 33664: (follow-up) Move check for 'received' to include Modify link |
Description
Katrin Fischer
2023-05-03 14:35:18 UTC
From my library days, I would say it was very common for me to cancel orders I had already sent to the vendor. Mostly when the vendor would later tell me it was not available anymore or they would never get it. In Koha, I'm not a fan of having to reopen the basket since like you said, it changes the order date. I had never tried option B. It seems like a fiddly workaround for something that should be possible. From a workflow standpoint, I don't think there is a reason to limit cancelling orders to open baskets only. From a technical standpoint, we should probably look at what closing the basket does, to know if something would clash with cancelling the order. AFAIK it changes the status if it was new to ordered. If it was received it remains the same. Otherwise it should not change a thing and you can already cancel new from the basket and ordered from the receive page... so I think we should be ok. (In reply to Caroline Cyr La Rose from comment #1) > From my library days, I would say it was very common for me to cancel orders > I had already sent to the vendor. Mostly when the vendor would later tell me > it was not available anymore or they would never get it. > > In Koha, I'm not a fan of having to reopen the basket since like you said, > it changes the order date. I had never tried option B. It seems like a > fiddly workaround for something that should be possible. > I agree. And yes, it is common to cancel order lines because titles are not available We often cancel orders, from reception module. It would be more convenient to be able to cancel orders from basket Created attachment 154045 [details] [review] Bug 33664: Add ability to cancel order lines in closed baskets At the moment it's only possible to cancel order lines while the basket is still open or from the pending orders page during processing a shipment. The latter requires you to add a shipment and fake an invoice. To make things easier we want to optionally allow cancelling order lines in closed baskets from the basket summary page. Before applying the patch: 1) Set up data * Create a new basket * Create a few order lines, at least 3 * Close the basket * Receive shipment and receive one order line 2) Verify current behaviour * On basket summary page: you cannot cancel while the basket is closed * On the pending orders page you can cancel Apply patch, run database update, restart_all 3) Verify new behaviour * Verify that nothing has changed on pending orders and basket summary * Switch new system preference CancelOrdersInClosedBaskets to "Allow" * Verify that pending orders hasn't changed a bit * Verify that you now can cancel your order lines in the closed basket Exception: the received order line should not be cancellable Test anything else that you think might make sense ;) Created attachment 154053 [details] [review] Bug 33664: Add ability to cancel order lines in closed baskets At the moment it's only possible to cancel order lines while the basket is still open or from the pending orders page during processing a shipment. The latter requires you to add a shipment and fake an invoice. To make things easier we want to optionally allow cancelling order lines in closed baskets from the basket summary page. Before applying the patch: 1) Set up data * Create a new basket * Create a few order lines, at least 3 * Close the basket * Receive shipment and receive one order line 2) Verify current behaviour * On basket summary page: you cannot cancel while the basket is closed * On the pending orders page you can cancel Apply patch, run database update, restart_all 3) Verify new behaviour * Verify that nothing has changed on pending orders and basket summary * Switch new system preference CancelOrdersInClosedBaskets to "Allow" * Verify that pending orders hasn't changed a bit * Verify that you now can cancel your order lines in the closed basket Exception: the received order line should not be cancellable Test anything else that you think might make sense ;) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Created attachment 157979 [details] [review] Bug 33664: Add ability to cancel order lines in closed baskets At the moment it's only possible to cancel order lines while the basket is still open or from the pending orders page during processing a shipment. The latter requires you to add a shipment and fake an invoice. To make things easier we want to optionally allow cancelling order lines in closed baskets from the basket summary page. Before applying the patch: 1) Set up data * Create a new basket * Create a few order lines, at least 3 * Close the basket * Receive shipment and receive one order line 2) Verify current behaviour * On basket summary page: you cannot cancel while the basket is closed * On the pending orders page you can cancel Apply patch, run database update, restart_all 3) Verify new behaviour * Verify that nothing has changed on pending orders and basket summary * Switch new system preference CancelOrdersInClosedBaskets to "Allow" * Verify that pending orders hasn't changed a bit * Verify that you now can cancel your order lines in the closed basket Exception: the received order line should not be cancellable Test anything else that you think might make sense ;) Too many changes on this template lately, but all nicely rebased now! Created attachment 158075 [details] [review] Bug 33664: Add ability to cancel order lines in closed baskets At the moment it's only possible to cancel order lines while the basket is still open or from the pending orders page during processing a shipment. The latter requires you to add a shipment and fake an invoice. To make things easier we want to optionally allow cancelling order lines in closed baskets from the basket summary page. Before applying the patch: 1) Set up data * Create a new basket * Create a few order lines, at least 3 * Close the basket * Receive shipment and receive one order line 2) Verify current behaviour * On basket summary page: you cannot cancel while the basket is closed * On the pending orders page you can cancel Apply patch, run database update, restart_all 3) Verify new behaviour * Verify that nothing has changed on pending orders and basket summary * Switch new system preference CancelOrdersInClosedBaskets to "Allow" * Verify that pending orders hasn't changed a bit * Verify that you now can cancel your order lines in the closed basket Exception: the received order line should not be cancellable Test anything else that you think might make sense ;) Created attachment 158076 [details] [review] Bug 33664: (follow-up) Move check for 'received' to include Modify link Created attachment 158077 [details] [review] Bug 33664: Add ability to cancel order lines in closed baskets At the moment it's only possible to cancel order lines while the basket is still open or from the pending orders page during processing a shipment. The latter requires you to add a shipment and fake an invoice. To make things easier we want to optionally allow cancelling order lines in closed baskets from the basket summary page. Before applying the patch: 1) Set up data * Create a new basket * Create a few order lines, at least 3 * Close the basket * Receive shipment and receive one order line 2) Verify current behaviour * On basket summary page: you cannot cancel while the basket is closed * On the pending orders page you can cancel Apply patch, run database update, restart_all 3) Verify new behaviour * Verify that nothing has changed on pending orders and basket summary * Switch new system preference CancelOrdersInClosedBaskets to "Allow" * Verify that pending orders hasn't changed a bit * Verify that you now can cancel your order lines in the closed basket Exception: the received order line should not be cancellable Test anything else that you think might make sense ;) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 158078 [details] [review] Bug 33664: (follow-up) Move check for 'received' to include Modify link Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |