Summary: | Clicking on a system preference sub-menu item does not scroll to that item | ||
---|---|---|---|
Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
Component: | Templates | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | RESOLVED DUPLICATE | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jonathan.druart, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 32926 | ||
Bug Blocks: | |||
Attachments: |
Bug 33687: Restore scroll to sub-tab
Bug 33687: Restore scroll to sub-tab |
Description
Pedro Amorim
2023-05-05 12:15:32 UTC
Created attachment 150740 [details] [review] Bug 33687: Restore scroll to sub-tab Test plan: Go to sys prefs, click 'Enhanced Content' Click 'OverDrive', notice it doesnt scroll there Apply this patch: Do the same test plan, but notice it does scroll there, like before Created attachment 150748 [details] [review] Bug 33687: Restore scroll to sub-tab Test plan: Go to sys prefs, click 'Enhanced Content' Click 'OverDrive', notice it doesnt scroll there Apply this patch: Do the same test plan, but notice it does scroll there, like before Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Working as expected, fixes the regression from bug 32926 without causing further issues. Signing off Is it possible this was already fixed elsewhere or is browser dependent? I just tried without the patches applied and it works for me (Enhanced content - Overdrive) Also: patch currently doesn't apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33687: Restore scroll to sub-tab Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 33687: Restore scroll to sub-tab hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-33687-Restore-scroll-to-sub-tab-a82QmL.patch (In reply to Katrin Fischer from comment #4) > Is it possible this was already fixed elsewhere or is browser dependent? Please see earlier Bug 33634, looks like it was fixed there. However, as per the patch Pedro has provided here, the TT filter for the TAB.tab_id variable needs to be 'htmlId' instead of 'html'. (In reply to Katrin Fischer from comment #5) > Also: patch currently doesn't apply: Looks like the same line (line 200) in the template file was modified by commit 0d1278aa14b from Bug 33634. That would explain why this patch currently doesn't apply. |