Bug 33707

Summary: News vs Quote of the day styling on staff interface main page
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: jonathan.druart
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.07
Circulation function:
Attachments: Bug 33707: News vs Quote of the day styling on staff interface main page
Bug 33707: News vs Quote of the day styling on staff interface main page
Bug 33707: News vs Quote of the day styling on staff interface main page

Description Caroline Cyr La Rose 2023-05-09 20:49:22 UTC
I was updating the screenshots for the QOTD feature and noticed the styling for the news block and the styling for the QOTD block on the staff interface are slightly different.

To test:
- Have at least one news item for the staff interface (create one, load the sample ones in the web installer, or load the installer/data/mysql/en/optional/sample_news.yml file)
- Have at least one quote (create one, load the sample ones in the web installer, or load the installer/data/mysql/en/optional/sample_quotes.yml file)
- Enable the QuoteOfTheDay syspref for the staff interface
- Go to the staff interface main page
  --> The news font is grey
  --> The quote font is black (or at least darker grey)
Comment 1 Caroline Cyr La Rose 2023-05-09 20:50:45 UTC
I personally like the darker colour, as it's easier to read... but I'm not sure what the styling guide recommends
Comment 2 Owen Leonard 2023-05-10 12:44:12 UTC
Created attachment 150988 [details] [review]
Bug 33707: News vs Quote of the day styling on staff interface main page

This patch makes minor adjustments to the global and staff home page CSS
so that the display of news and quote-of-the-day are more consistent.

To test, apply the patch and rebuild the staff interface CSS.

- If necessary, add at least one news item (Tools -> News -> New entry)
  and at least one quote (Tools -> Quote editor -> New quote).
- View the staff interface home page to confirm that the style of the
  news area and the quotes is consistent.
Comment 3 Caroline Cyr La Rose 2023-05-10 13:10:10 UTC
Created attachment 150999 [details] [review]
Bug 33707: News vs Quote of the day styling on staff interface main page

This patch makes minor adjustments to the global and staff home page CSS
so that the display of news and quote-of-the-day are more consistent.

To test, apply the patch and rebuild the staff interface CSS.

- If necessary, add at least one news item (Tools -> News -> New entry)
  and at least one quote (Tools -> Quote editor -> New quote).
- View the staff interface home page to confirm that the style of the
  news area and the quotes is consistent.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 4 Jonathan Druart 2023-05-11 07:46:07 UTC
Created attachment 151050 [details] [review]
Bug 33707: News vs Quote of the day styling on staff interface main page

This patch makes minor adjustments to the global and staff home page CSS
so that the display of news and quote-of-the-day are more consistent.

To test, apply the patch and rebuild the staff interface CSS.

- If necessary, add at least one news item (Tools -> News -> New entry)
  and at least one quote (Tools -> Quote editor -> New quote).
- View the staff interface home page to confirm that the style of the
  news area and the quotes is consistent.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Jonathan Druart 2023-05-16 09:52:30 UTC
Pushed to master for 23.05
Comment 6 Pedro Amorim 2023-06-07 10:16:42 UTC
Nice work everyone!

Pushed to 22.11.x for next release