| Summary: | Merge Calendar tests | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | lucas, martin.renvoize, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08,22.05.16
|
|
| Circulation function: | |||
| Attachments: |
Bug 33727: Groundwork for Calendar.t
Bug 33727: Merge both Calendar tests Bug 33727: Groundwork for Calendar.t Bug 33727: Merge both Calendar tests Bug 33727: Groundwork for Calendar.t Bug 33727: Merge both Calendar tests Bug 33727: (QA follow-up) perl tidy whole file |
||
|
Description
Marcel de Rooy
2023-05-13 12:25:44 UTC
Created attachment 151165 [details] [review] Bug 33727: Groundwork for Calendar.t Update test while removing need for Test::DBIx::Class. Test plan: Run t/Calendar.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 151166 [details] [review] Bug 33727: Merge both Calendar tests The old t tests become part of the first subtest. Test plan: Run the new t/db_dependent/Calendar.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 151168 [details] [review] Bug 33727: Groundwork for Calendar.t Update test while removing need for Test::DBIx::Class. Test plan: Run t/Calendar.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 151169 [details] [review] Bug 33727: Merge both Calendar tests The old t tests become part of the first subtest. Test plan: Run the new t/db_dependent/Calendar.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Top of the SO list now. Trivial patch waiting for 2 months already ;) Taking liberty to get it further now myself. prove t/db_dependent/Calendar.t
t/db_dependent/Calendar.t .. ok
All tests successful.
Files=1, Tests=6, 2 wallclock secs ( 0.05 usr 0.01 sys + 2.23 cusr 0.21 csys = 2.50 CPU)
Result: PASS
WARN t/db_dependent/Calendar.t
WARN tidiness
The file is less tidy than before (bad/messy lines before: 71, now: 210)
OK valid
OK OK Will run it thru perltidy
Created attachment 153432 [details] [review] Bug 33727: Groundwork for Calendar.t Update test while removing need for Test::DBIx::Class. Test plan: Run t/Calendar.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 153433 [details] [review] Bug 33727: Merge both Calendar tests The old t tests become part of the first subtest. Test plan: Run the new t/db_dependent/Calendar.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 153434 [details] [review] Bug 33727: (QA follow-up) perl tidy whole file Test plan: Run prove again. Run qa tools. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> OK t/db_dependent/Calendar.t OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling OK tidiness OK valid Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x Backported to 22.05.x for upcoming 22.05.16 |