Bug 33765

Summary: Accessibility: Fix ambiguous form-field in opac-main.tt
Product: Koha Reporter: Matt Blenkinsop <matt.blenkinsop>
Component: TemplatesAssignee: Matt Blenkinsop <matt.blenkinsop>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: Laura.escamilla, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 23003    
Attachments: Bug 33765: Fix ambiguous "Login" field
Bug 33765: Fix ambiguous "Login" field

Description Matt Blenkinsop 2023-05-18 12:58:27 UTC
The form field for "userid" is called Login. This is confusing for screen readers and has been flagged as non-compliant in an accessibility report carried out for the British Museum.
Comment 1 Matt Blenkinsop 2023-05-18 13:01:27 UTC
Created attachment 151415 [details] [review]
Bug 33765: Fix ambiguous "Login" field

This patch changes the use of "Login" to "Username" to assist with screen reading

Test plan:
1) On the OPAC main page, the log in form should now have the first field labelled as Username, not Login
Comment 2 ByWater Sandboxes 2023-05-18 15:29:12 UTC
Created attachment 151425 [details] [review]
Bug 33765: Fix ambiguous "Login" field

This patch changes the use of "Login" to "Username" to assist with screen reading

Test plan:
1) On the OPAC main page, the log in form should now have the first field labelled as Username, not Login

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 3 Marcel de Rooy 2023-05-19 09:23:53 UTC
What about:

git grep ">Login:"
intranet-tmpl/prog/en/modules/acqui/supplier.tt:                            <p><span>Login: [% i.login | html %]</span></p>
opac-tmpl/bootstrap/en/includes/masthead.inc:                                    <label for="muserid">Login:</label><input type="text" id="muserid" name="userid" autocomplete="off" />
opac-tmpl/bootstrap/en/modules/opac-auth.tt:                                            <label for="userid">Login:</label>
opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt:                                    <label for="username">Login:</label>
opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt:                                        <label for="userid">Login:</label>
opac-tmpl/bootstrap/en/modules/opac-reset-password.tt:                                    <label for="userid">Login:</label>
opac-tmpl/bootstrap/en/modules/sco/sco-main.tt:                                            <label for="patronlogin">Login:</label>
Comment 4 Matt Blenkinsop 2023-05-19 13:54:08 UTC
In light of the ongoing discussion on bug 33766 I think its best to close this bug and bug 33764 and wrap all instances of this issue into bug 33766 when the discussion is concluded

*** This bug has been marked as a duplicate of bug 33766 ***