Bug 33767

Summary: Accessibility: The 'OPAC results' page contains semantically incorrect headings
Product: Koha Reporter: Matt Blenkinsop <matt.blenkinsop>
Component: OPACAssignee: Matt Blenkinsop <matt.blenkinsop>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: m.de.rooy, martin.renvoize
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.07
Bug Depends on:    
Bug Blocks: 25150    
Attachments: Bug 33767: Fix incorrect heading in page-numbers.inc
Bug 33767: Fix incorrect heading in page-numbers.inc
Bug 33767: Fix incorrect heading in page-numbers.inc

Description Matt Blenkinsop 2023-05-18 13:52:52 UTC
The OPAC results page contains an illogical skip from an H2 to H6 through the injection of page-numbers.inc. This can be replaced with a span with a class of h6 to maintain formatting.
Comment 1 Matt Blenkinsop 2023-05-18 13:58:05 UTC
Created attachment 151419 [details] [review]
Bug 33767: Fix incorrect heading in page-numbers.inc

This patch replaces an h6 with a span to avoid a jump from h2 to h6.
Comment 2 Owen Leonard 2023-05-18 14:26:24 UTC
Created attachment 151420 [details] [review]
Bug 33767: Fix incorrect heading in page-numbers.inc

This patch replaces an h6 with a span to avoid a jump from h2 to h6.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2023-05-19 09:21:13 UTC
Created attachment 151463 [details] [review]
Bug 33767: Fix incorrect heading in page-numbers.inc

This patch replaces an h6 with a span to avoid a jump from h2 to h6.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi 2023-05-19 12:21:23 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-06-08 16:58:27 UTC
Nice work everyone!

Pushed to stable for 22.11.x