Bug 33778

Summary: Move t/Auth_with_shibboleth.t to db_dependent
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Architecture, internals, and plumbingAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: martin.renvoize, pedro.amorim
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02
Circulation function:
Bug Depends on: 33777    
Bug Blocks:    
Attachments: Bug 33778: Remove T::D::C from Auth_with_shibboleth.t
Bug 33778: Further polishing
Bug 33778: Fix indentation of last subtest
Bug 33778: Move to db_dependent
Bug 33778: Remove T::D::C from Auth_with_shibboleth.t
Bug 33778: Further polishing
Bug 33778: Fix indentation of last subtest
Bug 33778: Move to db_dependent
Bug 33778: Remove T::D::C from Auth_with_shibboleth.t
Bug 33778: Further polishing
Bug 33778: Fix indentation of last subtest
Bug 33778: Move to db_dependent
Bug 33778: (QA follow-up) Update for master

Description Marcel de Rooy 2023-05-19 06:24:10 UTC

    
Comment 1 Marcel de Rooy 2023-05-19 08:53:20 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2023-05-19 08:53:22 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2023-05-19 08:53:24 UTC Comment hidden (obsolete)
Comment 4 Marcel de Rooy 2023-05-19 08:53:26 UTC Comment hidden (obsolete)
Comment 5 David Nind 2023-05-19 19:46:30 UTC
Created attachment 151494 [details] [review]
Bug 33778: Remove T::D::C from Auth_with_shibboleth.t

This test should be in t/db. It needs patrons, categories, branches.
T::D::C now hides e.g. the branchcode constraint.
When removing T::D::C, we therefore need to add a branchcode in the
shibboleth test config.

Test plan:
Run t/Auth_with_shibboleth.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2023-05-19 19:46:33 UTC
Created attachment 151495 [details] [review]
Bug 33778: Further polishing

Use mock_preference.
Move final tests for BaseURLs into one subtest.
Change reset_config to allow passing parameters replacing some variables.
Copyright line.

Test plan:
Run t/Auth_with_shibboleth.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2023-05-19 19:46:35 UTC
Created attachment 151496 [details] [review]
Bug 33778: Fix indentation of last subtest

Only whitespace.

Test plan:
git diff -w HEAD~1.. t/Auth_with_shibboleth.t
No differences.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Comment 8 David Nind 2023-05-19 19:46:38 UTC
Created attachment 151497 [details] [review]
Bug 33778: Move to db_dependent

Test plan:
Run t/db_dependent/Auth_with_shibboleth.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Comment 9 Martin Renvoize (ashimema) 2023-06-26 11:02:47 UTC
Created attachment 152672 [details] [review]
Bug 33778: Remove T::D::C from Auth_with_shibboleth.t

This test should be in t/db. It needs patrons, categories, branches.
T::D::C now hides e.g. the branchcode constraint.
When removing T::D::C, we therefore need to add a branchcode in the
shibboleth test config.

Test plan:
Run t/Auth_with_shibboleth.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize (ashimema) 2023-06-26 11:02:50 UTC
Created attachment 152673 [details] [review]
Bug 33778: Further polishing

Use mock_preference.
Move final tests for BaseURLs into one subtest.
Change reset_config to allow passing parameters replacing some variables.
Copyright line.

Test plan:
Run t/Auth_with_shibboleth.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 11 Martin Renvoize (ashimema) 2023-06-26 11:02:53 UTC
Created attachment 152674 [details] [review]
Bug 33778: Fix indentation of last subtest

Only whitespace.

Test plan:
git diff -w HEAD~1.. t/Auth_with_shibboleth.t
No differences.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 12 Martin Renvoize (ashimema) 2023-06-26 11:02:56 UTC
Created attachment 152675 [details] [review]
Bug 33778: Move to db_dependent

Test plan:
Run t/db_dependent/Auth_with_shibboleth.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 13 Martin Renvoize (ashimema) 2023-06-26 11:02:59 UTC
Created attachment 152676 [details] [review]
Bug 33778: (QA follow-up) Update for master

The error message was updated in master.
Comment 14 Martin Renvoize (ashimema) 2023-06-26 11:05:06 UTC
Nice cleanup, thanks.

Tests all working as expected, simplified and modernised.

Passing QA
Comment 15 Tomás Cohen Arazi (tcohen) 2023-06-29 14:08:46 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 16 Martin Renvoize (ashimema) 2023-07-17 14:46:59 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 17 Pedro Amorim 2023-07-18 11:57:36 UTC
Enhancement. Not pushing to 22.11.x.