| Summary: | Items tab shows all previous borrowers instead of 3 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Sara Brown <sbrown> |
| Component: | Staff interface | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | blawlor, fridolin.somers, gmcharlt, kebliss, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.07
|
|
| Circulation function: | |||
| Bug Depends on: | 32272 | ||
| Bug Blocks: | |||
| Attachments: |
moredetail.pl
Bug 33788: Limit the number of old issues rows returned Bug 33788: Limit the number of old issues rows returned |
||
|
Description
Sara Brown
2023-05-19 17:40:52 UTC
One possible workaround I thought of would be to use javascript to remove all children <li> after the sixth one in the <ol class="bibliodetails"> on the item details page. Created attachment 151763 [details] [review] Bug 33788: Limit the number of old issues rows returned This patch updates the parameter from 'limit' to 'rows' To test: 1 - Checkout an item to 5 different people 2 - View item details on items tab of record 3 - Note you see last borrower, and three previous borrowers 4 - Apply patch, restart all 5 - Refresh page 6 - You shoulw now only see last borrower and 2 previous borrowers Created attachment 151782 [details] [review] Bug 33788: Limit the number of old issues rows returned This patch updates the parameter from 'limit' to 'rows' To test: 1 - Checkout an item to 5 different people 2 - View item details on items tab of record 3 - Note you see last borrower, and three previous borrowers 4 - Apply patch, restart all 5 - Refresh page 6 - You shoulw now only see last borrower and 2 previous borrowers Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Very small, save, no strings. Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Good catch ;) The doc : https://metacpan.org/pod/DBIx::Class::ResultSet#rows |