Summary: | Checkout information is missing when adding a credit | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Fines and fees | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Needs documenting --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, Laura.escamilla, matt.blenkinsop |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.11.00,23.05.01
|
Circulation function: | |
Attachments: |
Bug 33789: Return issue info. when adding a credit
Bug 33789: Return issue info. when adding a credit Bug 33789: Add unit test Bug 33789: Return issue info. when adding a credit Bug 33789: Add unit test Bug 33789: Update POD |
Description
Lucas Gass (lukeg)
2023-05-19 22:02:32 UTC
Created attachment 151498 [details] [review] Bug 33789: Return issue info. when adding a credit To test: 1. Make sure MarkLostItemsAsReturned is set so a lost item will stay on a patrons account after being marked as lost. 2. Check an item out to a patron, make sure it has a replacementprice 3. Mark the item as lost. 4. Now check the item in. 5. Go to the patrons account -> transaction tab. You should see 2 accountlines related to the item. 6. For the account type 'Lost item' you will see issue infomation ( check out date, due date, checkouted out from, etc ) 7. For the account type 'Lost item fee refund' there is no issue information. 8. Apply patch 9. Try 2 - 6 again. This time the 'Lost item fee refund' should include issue information. Created attachment 151528 [details] [review] Bug 33789: Return issue info. when adding a credit To test: 1. Make sure MarkLostItemsAsReturned is set so a lost item will stay on a patrons account after being marked as lost. 2. Check an item out to a patron, make sure it has a replacementprice 3. Mark the item as lost. 4. Now check the item in. 5. Go to the patrons account -> transaction tab. You should see 2 accountlines related to the item. 6. For the account type 'Lost item' you will see issue infomation ( check out date, due date, checkouted out from, etc ) 7. For the account type 'Lost item fee refund' there is no issue information. 8. Apply patch 9. Try 2 - 6 again. This time the 'Lost item fee refund' should include issue information. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Please provide a test. Created attachment 151650 [details] [review] Bug 33789: Add unit test Created attachment 151897 [details] [review] Bug 33789: Return issue info. when adding a credit To test: 1. Make sure MarkLostItemsAsReturned is set so a lost item will stay on a patrons account after being marked as lost. 2. Check an item out to a patron, make sure it has a replacementprice 3. Mark the item as lost. 4. Now check the item in. 5. Go to the patrons account -> transaction tab. You should see 2 accountlines related to the item. 6. For the account type 'Lost item' you will see issue infomation ( check out date, due date, checkouted out from, etc ) 7. For the account type 'Lost item fee refund' there is no issue information. 8. Apply patch 9. Try 2 - 6 again. This time the 'Lost item fee refund' should include issue information. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 151898 [details] [review] Bug 33789: Add unit test JD amended patch: Remove biblionumber => 144 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 152014 [details] [review] Bug 33789: Update POD Pushed to master for 23.11. Nice work everyone, thanks! Pushed to master for 23.05. Nice work everyone, thanks! Enhancement - not backporting to 22.11.x |