Bug 33811

Summary: Overridden checkin dates are not respected at all when CircConfirmItemParts enabled and item has parts note
Product: Koha Reporter: Andrew Fuerste-Henry <andrew>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, kyle.m.hall, nick
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 33806    
Bug Blocks:    

Description Andrew Fuerste-Henry 2023-05-23 14:52:06 UTC
To recreate:
1 - turn on CircConfirmItemParts 
2 - have an item with a value in the 952$3
3 - check the item out
4 - go to the checkin page, set a due date in the past, check the item in
5 - run a report to find the returndate for your issue in old_issues, confirm that it shows the actual date of your checkin, not the manually overridden date
6 - Repeats steps 3 and 4 with an item without a 952$3
7 - confirm via report that the returndate for this issue shows the overridden date

With the patch from 33806, if one checks the "Remember return date for next check in" box then the overridden returndate *is* correctly recorded in old_issues. But only if you check the box.