Description
Owen Leonard
2023-05-24 15:05:19 UTC
Created attachment 151639 [details] [review] Bug 33820: Add hints to warn the librarian that they will be logged out if they change their username This patch adds some JavaScript to the patron entry form which adds a hint if the logged-in librarian tries to change their own username. It warns them that they will be logged out. To test, apply the patch and log into the staff interface. - Locate and edit your own patron record. - In the "OPAC/Staff interface login" section, change the value in the username field. When focus leaves that form field a hint should appear, "You will be logged out if you modify your username." - Change the username field back to your original username. The hint should disappear. - Confirm that submitting a username change works correctly: You should be logged out, and when you log in again your username should be updated. Created attachment 151640 [details] [review] Bug 33820: (follow-up) Add hint to member-password.tt This follow-up makes the same change to the "Change password" template. First attachment works as expected. The problem occurs when clicking on the "Change Password" template. When editing the username, the hint occurs properly, however, if you press save changes while leaving the new password fields blank, the username doesn't change and it does not log you out. In order for the username change to take effect, you have to enter a new password which basically goes against the text that is listed at the bottom of this page: "Koha cannot display existing passwords. Leave the field blank to leave password unchanged." (In reply to Sam Lau from comment #3) > In > order for the username change to take effect, you have to enter a new > password which basically goes against the text that is listed at the bottom > of this page: > > "Koha cannot display existing passwords. Leave the field blank to leave > password unchanged." This issue is unrelated to the patch, so I've created Bug 33832. Created attachment 151685 [details] [review] Bug 33820: Add hints to warn the librarian that they will be logged out if they change their username This patch adds some JavaScript to the patron entry form which adds a hint if the logged-in librarian tries to change their own username. It warns them that they will be logged out. To test, apply the patch and log into the staff interface. - Locate and edit your own patron record. - In the "OPAC/Staff interface login" section, change the value in the username field. When focus leaves that form field a hint should appear, "You will be logged out if you modify your username." - Change the username field back to your original username. The hint should disappear. - Confirm that submitting a username change works correctly: You should be logged out, and when you log in again your username should be updated. Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 151686 [details] [review] Bug 33820: (follow-up) Add hint to member-password.tt This follow-up makes the same change to the "Change password" template. Signed-off-by: Sam Lau <samalau@gmail.com> Technically this works but the hints are very easy to miss/ignore. Even when I was looking for it, I didn't even notice it the first time or two. I think adding color, bolding, or maybe even a prefix like "Warning!" might help this to stand out. But perhaps that could be a follow up. Not enough of an issue to block this I think. Created attachment 151717 [details] [review] Bug 33820: Add hints to warn the librarian that they will be logged out if they change their username This patch adds some JavaScript to the patron entry form which adds a hint if the logged-in librarian tries to change their own username. It warns them that they will be logged out. To test, apply the patch and log into the staff interface. - Locate and edit your own patron record. - In the "OPAC/Staff interface login" section, change the value in the username field. When focus leaves that form field a hint should appear, "You will be logged out if you modify your username." - Change the username field back to your original username. The hint should disappear. - Confirm that submitting a username change works correctly: You should be logged out, and when you log in again your username should be updated. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: David Cook <dcook@prosentient.com.au> Created attachment 151718 [details] [review] Bug 33820: (follow-up) Add hint to member-password.tt This follow-up makes the same change to the "Change password" template. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: David Cook <dcook@prosentient.com.au> Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Enhancement, not backporting to 22.11.x |