Bug 33828

Summary:	ExportCircHistory description is misleading
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	System Administration	Assignee:	Bugs List <koha-bugs>
Status:	RESOLVED FIXED	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	fridolin.somers, gmcharlt, martin.renvoize
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:	Caroline Cyr La Rose	Documentation submission:	https://gitlab.com/koha-community/koha-manual/-/merge_requests/774
Text to go in the release notes:		Version(s) released in:	23.11.00
Circulation function:
Attachments:	Bug 33828: ExportCircHistory description is misleading Bug 33828: ExportCircHistory description is misleading Bug 33828: ExportCircHistory description is misleading

Description Caroline Cyr La Rose 2023-05-24 20:37:40 UTC

The description for ExportCircHistory is currently

[Show/Don't show] the export patron checkout history options.

However, the option to export is only available for the patron's current checkouts, not their checkout history.

Either we add ExportCircHistory in members/readingrec.pl (circulation history) or we rename/change the description to say that this pref is used to export current checkouts.

Current behaviour:

1. Enable ExportCircHistory

2. Go to a patron's account who has checkouts, or check out some items to a patron
   --> Note that in the checkouts table at the bottom of the page, there is an 'Export' column and at the bottom of the table, there are export options

3. Go to the patron's Details tab 
   --> Note that in the checkouts table at the bottom of the page, there is an 'Export' column and at the bottom of the table, there are export options

4. Go to the patron's Circulation history tab
   --> No additional export options (other than the datatables thing)

Comment 1 Caroline Cyr La Rose 2023-05-24 20:58:35 UTC

ExportRemoveFields also mentions the "patron checkout history", but like ExportCircHistory it has nothing to do with the checkout history (both prefs are linked).

Comment 2 Caroline Cyr La Rose 2023-06-22 18:58:36 UTC

Created attachment 152578 [details] [review]
Bug 33828: ExportCircHistory description is misleading

This patch removes the mention of checkout history from the
ExportCircHistory system preference description, as this system
preference only allows to export current checkouts, not checkout
history.

This patch also modifies the description of the ExportRemoveFields
system preference to also remove mention of checkout history.

To test:
0. Apply patch
1. Go to Administration > System preferences > Circulation
2. Read the description for ExportCircHistory, make sure it makes sense,
   and that spelling and syntax are correct
3. Read the description for ExportRemoveFields, make sure it makes
   sense, and that spelling and syntax are correct

Comment 3 Caroline Cyr La Rose 2023-06-22 19:00:49 UTC

I'm not convinced this is the way to go, but I corrected the descriptions for ExportCircHistory and ExportRemoveFields to remove mention of checkout history.

I think it would be better to expand the functionality to checkout history, but it is outside my abilities. At least this way it removes a bit of confusion.

Comment 4 Sam Lau 2023-08-03 15:33:36 UTC

Created attachment 154221 [details] [review]
Bug 33828: ExportCircHistory description is misleading

This patch removes the mention of checkout history from the
ExportCircHistory system preference description, as this system
preference only allows to export current checkouts, not checkout
history.

This patch also modifies the description of the ExportRemoveFields
system preference to also remove mention of checkout history.

To test:
0. Apply patch
1. Go to Administration > System preferences > Circulation
2. Read the description for ExportCircHistory, make sure it makes sense,
   and that spelling and syntax are correct
3. Read the description for ExportRemoveFields, make sure it makes
   sense, and that spelling and syntax are correct

Signed-off-by: Sam Lau <samalau@gmail.com>

Comment 5 Martin Renvoize (ashimema) 2023-09-18 10:40:32 UTC

Created attachment 155793 [details] [review]
Bug 33828: ExportCircHistory description is misleading

This patch removes the mention of checkout history from the
ExportCircHistory system preference description, as this system
preference only allows to export current checkouts, not checkout
history.

This patch also modifies the description of the ExportRemoveFields
system preference to also remove mention of checkout history.

To test:
0. Apply patch
1. Go to Administration > System preferences > Circulation
2. Read the description for ExportCircHistory, make sure it makes sense,
   and that spelling and syntax are correct
3. Read the description for ExportRemoveFields, make sure it makes
   sense, and that spelling and syntax are correct

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 6 Martin Renvoize (ashimema) 2023-09-18 10:40:50 UTC

Trivial QA.. Passed.

Comment 7 Tomás Cohen Arazi (tcohen) 2023-09-19 19:35:34 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 8 Fridolin Somers 2023-09-21 06:23:34 UTC

Enhancement not pushed to 23.05.x