| Summary: | api/v1/ill_requests.t fails randomly | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Test Suite | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | jonathan.druart, pedro.amorim, tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.07
|
|
| Circulation function: | |||
| Bug Depends on: | 22440 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 33834: Fix random failure on api/v1/ill_requests.t
Bug 33834: Fix random failure on api/v1/ill_requests.t |
||
|
Description
Tomás Cohen Arazi (tcohen)
2023-05-25 13:14:00 UTC
Created attachment 151678 [details] [review] Bug 33834: Fix random failure on api/v1/ill_requests.t This patch makes the GET request results more deterministic so we avoid random failures. It does so by adding a fixed value to each ILL request and then sorting by it. To test: 1. Run: $ DB_IMAGE=mysqli:8.0 ktd up -d # wait until it finished: $ ktd --logs 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/ill_requests.t (repeat a few times) => FAIL: It sometimes fails 3. Apply this patch 4. Repeat 2 => SUCCESS: It doesn't fail 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 151719 [details] [review] Bug 33834: Fix random failure on api/v1/ill_requests.t This patch makes the GET request results more deterministic so we avoid random failures. It does so by adding a fixed value to each ILL request and then sorting by it. To test: 1. Run: $ DB_IMAGE=mysqli:8.0 ktd up -d # wait until it finished: $ ktd --logs 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/ill_requests.t (repeat a few times) => FAIL: It sometimes fails 3. Apply this patch 4. Repeat 2 => SUCCESS: It doesn't fail 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x |